fix(browser): Use DedicatedWorkerGlobalScope global object type in registerWebWorker
#17447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
requested review from
a team,
stephanie-anderson,
s1gr1d and
andreiborza
and removed request for
a team and
stephanie-anderson
Lms24
changed the title
registerWebWorkerDedicatedWorkerGlobalScope global object type in registerWebWorker
3 tasks
andreiborza
approved these changes
Aug 25, 2025
3 tasks
s1gr1d
approved these changes
Aug 25, 2025
Lms24
force-pushed
the
lms/fix-browser-web-worker-types
branch
from
4c38041 to
9492a5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like I used the wrong type for the
selfglobal object users must pass intoSentry.registerWebWorkerinitially. This PR changes the type fromWebWorkertoDedicatedWorkerGlobalScope*. Other worker types don't supportpostMessage, so this type correctly scopes the API to its intended use (i.e. in dedicated workers).Also fixed a couple of incorrect references to
registerWebWorkerin JSDoc.*I couldn't actually use
DedicatedWorkerGlobalScopebecause it is only available if you addto your
tsconfig.json. So we would break existing setups without this lib option (very likely) andskipLibCheck: false(somewhat likely). Therefore I created a minimal interface that only requirespostMessagecloses #17444
ref #17443