Skip to content

fix(core): Only set template attributes on logs if parameters exist #17480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2025
+13 −1
Merged

fix(core): Only set template attributes on logs if parameters exist #17480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63dd9b8
fix(core): Only set templates if parameters exist
AbhiPrasad Aug 28, 2025
b4dbaba
Merge branch 'develop' into abhi-param-without-parameters
AbhiPrasad Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/core/src/logs/exports.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,9 @@ export function _INTERNAL_captureLog(
const beforeLogMessage = beforeLog.message;
if (isParameterizedString(beforeLogMessage)) {
const { __sentry_template_string__, __sentry_template_values__ = [] } = beforeLogMessage;
processedLogAttributes['sentry.message.template'] = __sentry_template_string__;
if (__sentry_template_values__?.length) {
processedLogAttributes['sentry.message.template'] = __sentry_template_string__;
}
__sentry_template_values__.forEach((param, index) => {
processedLogAttributes[`sentry.message.parameter.${index}`] = param;
});
Expand Down
10 changes: 10 additions & 0 deletions packages/core/test/lib/logs/exports.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,16 @@ describe('_INTERNAL_captureLog', () => {
});
});

it('does not set the template attribute if there are no parameters', () => {
const options = getDefaultTestClientOptions({ dsn: PUBLIC_DSN, enableLogs: true });
const client = new TestClient(options);

_INTERNAL_captureLog({ level: 'debug', message: fmt`User logged in` }, client, undefined);

const logAttributes = _INTERNAL_getLogBuffer(client)?.[0]?.attributes;
expect(logAttributes).toEqual({});
});

it('processes logs through beforeSendLog when provided', () => {
const beforeSendLog = vi.fn().mockImplementation(log => ({
...log,
Expand Down
Loading