Skip to content

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Sep 1, 2025

This PR ensures we shut down the SDKs internal OTel TraceProvider (if internal OTel SDK is intialized), when calling Sentry.close() (or rather NodeClient::close). Also added a couple of tests for client report and log flusher intervals.

@Lms24 Lms24 changed the title fix(node-core): Shut down OTel Traceprovider when calling Sentry.close() fix(node-core): Shut down OTel TraceProvider when calling Sentry.close() Sep 1, 2025
@Lms24 Lms24 requested review from andreiborza and mydea September 1, 2025 09:14
@Lms24 Lms24 self-assigned this Sep 1, 2025
cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

github-actions bot commented Sep 1, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.16 kB - -
@sentry/browser - with treeshaking flags 22.73 kB - -
@sentry/browser (incl. Tracing) 39.87 kB - -
@sentry/browser (incl. Tracing, Replay) 78.23 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 68.02 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 82.91 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 95.03 kB - -
@sentry/browser (incl. Feedback) 40.83 kB - -
@sentry/browser (incl. sendFeedback) 28.81 kB - -
@sentry/browser (incl. FeedbackAsync) 33.7 kB - -
@sentry/react 25.88 kB - -
@sentry/react (incl. Tracing) 41.89 kB - -
@sentry/vue 28.64 kB - -
@sentry/vue (incl. Tracing) 41.69 kB - -
@sentry/svelte 24.18 kB - -
CDN Bundle 25.66 kB - -
CDN Bundle (incl. Tracing) 39.75 kB - -
CDN Bundle (incl. Tracing, Replay) 76.03 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 81.46 kB - -
CDN Bundle - uncompressed 74.96 kB - -
CDN Bundle (incl. Tracing) - uncompressed 117.59 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 232.68 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 245.3 kB - -
@sentry/nextjs (client) 43.89 kB - -
@sentry/sveltekit (client) 40.32 kB - -
@sentry/node-core 48.01 kB +0.04% +18 B 🔺
@sentry/node 149.27 kB +0.02% +23 B 🔺
@sentry/node - without tracing 92.25 kB +0.02% +10 B 🔺
@sentry/aws-serverless 104.91 kB +0.01% +8 B 🔺

View base workflow run

Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this! Wondering if we should backport this to v9 as well 🤔.

@Lms24
Copy link
Member Author

Lms24 commented Sep 1, 2025

We could but I don't think the user impact is that large.

@Lms24 Lms24 merged commit 4c6c012 into develop Sep 1, 2025
262 of 263 checks passed
@Lms24 Lms24 deleted the lms/fix-node-core-shutdown-otel-traceProvider branch September 1, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants