Skip to content

Conversation

andreiborza
Copy link
Member

No description provided.

Lms24 and others added 19 commits August 29, 2025 10:22
chore(repo): Manually sync master -> develop
I think we originally decided to only have a error + feedback bundle and
a error + tracing + replay + feedback bundle for simplicity. But I
suppose it does not really make things easier that there is exactly one
(error + replay + feedback) missing, so I'd just add this here now. Esp.
if we want to add this in the loader this will be much easier to handle.
This adds the `sendFeedback` method to the CDN bundle exports. This
should not really add bundle size as this is used by the feedback
integration anyhow I believe.

(Some unrelated prettier fixes somehow also got into this PR, not sure
how this got on develop)
This simplifies our prettier setup to also run on e2e-tests, and aligns
the `fix:prettier` and `lint:prettier` targets (which were previously
not aligned).

Changes being done here:

1. Apply prettier to all e2e test apps normally (no special prettier
handling inside of the test apps)
2. Removed `.prettierrc.json` file, this was duplicated from the config
in the root package.json
3. Ensure prettier is applied to JSON files as well
4. Ensure prettier is applied to .astro files (needs astro plugin)
Follow up to #17497,
ignoring this from git blame.
…se()` (#17499)

Ensure we shut down the SDKs internal OTel TraceProvider (if
internal OTel SDK is intialized), when calling `Sentry.close()` (or
rather `NodeClient::close`).
…#17500)

Fix a bug in our Astro SDK's `browserTracingIntegration`.
Previously, if users followed our docs how to set a custom span name for
the pageload span [via
`beforeStartSpan`](https://docs.sentry.io/platforms/javascript/guides/astro/tracing/instrumentation/automatic-instrumentation/#beforeStartSpan),
the name would get overwritten by our route parameterization logic. This
was because the route parametrization logic ran after the span was
already created and it would simply update the span name.

In this case though, we can already start the span with the
parameterized name instead of updating after it was started.
- Speed up AWS E2E tests on CI by pulling a smaller Lambda image and not
re-pulling it on Lambda startup.
- Write SAM logs to stdout on CI instead of a temp file to help
debugging.
…in-place in `beforeStartSpan` (#17501)

When using `beforeStartSpan` in `browserTracingIntgration`, we document
that users should return a new options object rather than mutating the
passed in object in-place. However, nothing keeps users from setting the
name in-place like so:'

```js
browserTracingIntegration({
  beforeStartSpan: opts => {
    opts.name = 'changed';
    return opts;
  },
}),
```

In such a case, we previously didn't catch the mutation and wouldn't
adjust the span source attribute to `'custom'` accordingly. This PR
ensures we take care of this case, too. (found while writing a test for
#17500)
See
https://github.com/getsentry/sentry-javascript/actions/runs/17398257702/job/49385642947,
this seems to not trigger the failure, I guess this is `cancelled` not
`failure`

I could not really find good documentation on this but I suppose this
should work!
This adds a simple node express app that is run on CI to get very ~~
overhead measurements of using Sentry.

**THIS IS NOT NECESSARILY REPRESENTATIVE OF USING SENTRY IN A REAL
APP!** The app is very synthetic and real world numbers may vary wildly.

We run 3 endpoints with 3 scenarios each:

1. Minimal GET request:

```js
app.get('/test-get', function (req, res) {
  res.send({ version: 'v1' });
});
```

2. POST request with a bit of compute work:

```js
app.post('/test-post', function (req, res) {
  const body = req.body;
  res.send(generateResponse(body));
});

function generateResponse(body) {
  const bodyStr = JSON.stringify(body);
  const RES_BODY_SIZE = 10000;

  const bodyLen = bodyStr.length;
  let resBody = '';
  for (let i = 0; i < RES_BODY_SIZE; i++) {
    resBody += `${i}${bodyStr[i % bodyLen]}-`;
  }
  return { version: 'v1', length: bodyLen, resBody };
}
```

3. GET request with MySQL query:

```js
app.get('/test-mysql', function (_req, res) {
  pool.query('SELECT * from users').then(([users]) => {
    res.send({ version: 'v1', users });
  });
});
```

Each of these is run for 10s (after warmup) via
[autocannon](https://github.com/mcollina/autocannon), and we capture the
average # of requests per seconds. The scenarios are:

1. Plain, no Sentry/instrumentation
2. With "full" Sentry instrumentation:
```js
Sentry.init({
  dsn: process.env.E2E_TEST_DSN,
  tracesSampleRate: 1,
});
```
3, With errors-only Sentry instrumentation:
```js
Sentry.init({
  dsn: process.env.E2E_TEST_DSN
});
```
…17504)

Bumps
[actions/create-github-app-token](https://github.com/actions/create-github-app-token)
from 2.0.6 to 2.1.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/actions/create-github-app-token/releases">actions/create-github-app-token's
releases</a>.</em></p>
<blockquote>
<h2>v2.1.1</h2>
<h2><a
href="https://github.com/actions/create-github-app-token/compare/v2.1.0...v2.1.1">2.1.1</a>
(2025-08-11)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>revert &quot;use <code>node24</code> as runner&quot; (<a
href="https://redirect.github.com/actions/create-github-app-token/issues/278">#278</a>)
(<a
href="https://github.com/actions/create-github-app-token/commit/5204204e81cbd981afcdf714413410ba8697fd67">5204204</a>),
closes <a
href="https://redirect.github.com/actions/create-github-app-token/issues/267">actions/create-github-app-token#267</a></li>
</ul>
<h2>v2.1.0</h2>
<h1><a
href="https://github.com/actions/create-github-app-token/compare/v2.0.6...v2.1.0">2.1.0</a>
(2025-08-08)</h1>
<h3>Features</h3>
<ul>
<li>use <code>node24</code> as runner (<a
href="https://redirect.github.com/actions/create-github-app-token/issues/267">#267</a>)
(<a
href="https://github.com/actions/create-github-app-token/commit/a1cbe0fa3c5aa6b13e7437f226536549d68ed0dd">a1cbe0f</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/actions/create-github-app-token/commit/a8d616148505b5069dccd32f177bb87d7f39123b"><code>a8d6161</code></a>
build(release): 2.1.1 [skip ci]</li>
<li><a
href="https://github.com/actions/create-github-app-token/commit/5204204e81cbd981afcdf714413410ba8697fd67"><code>5204204</code></a>
fix: revert &quot;use <code>node24</code> as runner&quot; (<a
href="https://redirect.github.com/actions/create-github-app-token/issues/278">#278</a>)</li>
<li><a
href="https://github.com/actions/create-github-app-token/commit/0f859bf9e69e887678d5bbfbee594437cb440ffe"><code>0f859bf</code></a>
build(release): 2.1.0 [skip ci]</li>
<li><a
href="https://github.com/actions/create-github-app-token/commit/a1cbe0fa3c5aa6b13e7437f226536549d68ed0dd"><code>a1cbe0f</code></a>
feat: use <code>node24</code> as runner (<a
href="https://redirect.github.com/actions/create-github-app-token/issues/267">#267</a>)</li>
<li><a
href="https://github.com/actions/create-github-app-token/commit/d7ee28121512479a18a428398f948ac5ce15fb4c"><code>d7ee281</code></a>
build(deps-dev): bump the development-dependencies group across 1
directory w...</li>
<li><a
href="https://github.com/actions/create-github-app-token/commit/93c1f04d6f14ea5b416e7a8dfd80446101c6adef"><code>93c1f04</code></a>
build(deps-dev): bump the development-dependencies group with 4 updates
(<a
href="https://redirect.github.com/actions/create-github-app-token/issues/255">#255</a>)</li>
<li><a
href="https://github.com/actions/create-github-app-token/commit/dff4b11d10ecc84d937fdd0653d8343a88c5b9c4"><code>dff4b11</code></a>
ci(test): set <code>permissions</code> in test workflow (<a
href="https://redirect.github.com/actions/create-github-app-token/issues/247">#247</a>)</li>
<li><a
href="https://github.com/actions/create-github-app-token/commit/6d44c9fd24f9217ad0759aec3a68d36b34f68aa4"><code>6d44c9f</code></a>
docs(README): Client ID can be used as App ID (<a
href="https://redirect.github.com/actions/create-github-app-token/issues/251">#251</a>)</li>
<li>See full diff in <a
href="https://github.com/actions/create-github-app-token/compare/df432ceedc7162793a195dd1713ff69aefc7379e...a8d616148505b5069dccd32f177bb87d7f39123b">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/create-github-app-token&package-manager=github_actions&previous-version=2.0.6&new-version=2.1.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to
5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/actions/checkout/releases">actions/checkout's
releases</a>.</em></p>
<blockquote>
<h2>v5.0.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Update actions checkout to use node 24 by <a
href="https://github.com/salmanmkc"><code>@​salmanmkc</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/2226">actions/checkout#2226</a></li>
<li>Prepare v5.0.0 release by <a
href="https://github.com/salmanmkc"><code>@​salmanmkc</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/2238">actions/checkout#2238</a></li>
</ul>
<h2>⚠️ Minimum Compatible Runner Version</h2>
<p><strong>v2.327.1</strong><br />
<a
href="https://github.com/actions/runner/releases/tag/v2.327.1">Release
Notes</a></p>
<p>Make sure your runner is updated to this version or newer to use this
release.</p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/checkout/compare/v4...v5.0.0">https://github.com/actions/checkout/compare/v4...v5.0.0</a></p>
<h2>v4.3.0</h2>
<h2>What's Changed</h2>
<ul>
<li>docs: update README.md by <a
href="https://github.com/motss"><code>@​motss</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1971">actions/checkout#1971</a></li>
<li>Add internal repos for checking out multiple repositories by <a
href="https://github.com/mouismail"><code>@​mouismail</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1977">actions/checkout#1977</a></li>
<li>Documentation update - add recommended permissions to Readme by <a
href="https://github.com/benwells"><code>@​benwells</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/2043">actions/checkout#2043</a></li>
<li>Adjust positioning of user email note and permissions heading by <a
href="https://github.com/joshmgross"><code>@​joshmgross</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/2044">actions/checkout#2044</a></li>
<li>Update README.md by <a
href="https://github.com/nebuk89"><code>@​nebuk89</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/2194">actions/checkout#2194</a></li>
<li>Update CODEOWNERS for actions by <a
href="https://github.com/TingluoHuang"><code>@​TingluoHuang</code></a>
in <a
href="https://redirect.github.com/actions/checkout/pull/2224">actions/checkout#2224</a></li>
<li>Update package dependencies by <a
href="https://github.com/salmanmkc"><code>@​salmanmkc</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/2236">actions/checkout#2236</a></li>
<li>Prepare release v4.3.0 by <a
href="https://github.com/salmanmkc"><code>@​salmanmkc</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/2237">actions/checkout#2237</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/motss"><code>@​motss</code></a> made
their first contribution in <a
href="https://redirect.github.com/actions/checkout/pull/1971">actions/checkout#1971</a></li>
<li><a href="https://github.com/mouismail"><code>@​mouismail</code></a>
made their first contribution in <a
href="https://redirect.github.com/actions/checkout/pull/1977">actions/checkout#1977</a></li>
<li><a href="https://github.com/benwells"><code>@​benwells</code></a>
made their first contribution in <a
href="https://redirect.github.com/actions/checkout/pull/2043">actions/checkout#2043</a></li>
<li><a href="https://github.com/nebuk89"><code>@​nebuk89</code></a> made
their first contribution in <a
href="https://redirect.github.com/actions/checkout/pull/2194">actions/checkout#2194</a></li>
<li><a href="https://github.com/salmanmkc"><code>@​salmanmkc</code></a>
made their first contribution in <a
href="https://redirect.github.com/actions/checkout/pull/2236">actions/checkout#2236</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/checkout/compare/v4...v4.3.0">https://github.com/actions/checkout/compare/v4...v4.3.0</a></p>
<h2>v4.2.2</h2>
<h2>What's Changed</h2>
<ul>
<li><code>url-helper.ts</code> now leverages well-known environment
variables by <a href="https://github.com/jww3"><code>@​jww3</code></a>
in <a
href="https://redirect.github.com/actions/checkout/pull/1941">actions/checkout#1941</a></li>
<li>Expand unit test coverage for <code>isGhes</code> by <a
href="https://github.com/jww3"><code>@​jww3</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1946">actions/checkout#1946</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/checkout/compare/v4.2.1...v4.2.2">https://github.com/actions/checkout/compare/v4.2.1...v4.2.2</a></p>
<h2>v4.2.1</h2>
<h2>What's Changed</h2>
<ul>
<li>Check out other refs/* by commit if provided, fall back to ref by <a
href="https://github.com/orhantoy"><code>@​orhantoy</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1924">actions/checkout#1924</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/Jcambass"><code>@​Jcambass</code></a>
made their first contribution in <a
href="https://redirect.github.com/actions/checkout/pull/1919">actions/checkout#1919</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/checkout/compare/v4.2.0...v4.2.1">https://github.com/actions/checkout/compare/v4.2.0...v4.2.1</a></p>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/actions/checkout/blob/main/CHANGELOG.md">actions/checkout's
changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<h2>V5.0.0</h2>
<ul>
<li>Update actions checkout to use node 24 by <a
href="https://github.com/salmanmkc"><code>@​salmanmkc</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/2226">actions/checkout#2226</a></li>
</ul>
<h2>V4.3.0</h2>
<ul>
<li>docs: update README.md by <a
href="https://github.com/motss"><code>@​motss</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1971">actions/checkout#1971</a></li>
<li>Add internal repos for checking out multiple repositories by <a
href="https://github.com/mouismail"><code>@​mouismail</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1977">actions/checkout#1977</a></li>
<li>Documentation update - add recommended permissions to Readme by <a
href="https://github.com/benwells"><code>@​benwells</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/2043">actions/checkout#2043</a></li>
<li>Adjust positioning of user email note and permissions heading by <a
href="https://github.com/joshmgross"><code>@​joshmgross</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/2044">actions/checkout#2044</a></li>
<li>Update README.md by <a
href="https://github.com/nebuk89"><code>@​nebuk89</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/2194">actions/checkout#2194</a></li>
<li>Update CODEOWNERS for actions by <a
href="https://github.com/TingluoHuang"><code>@​TingluoHuang</code></a>
in <a
href="https://redirect.github.com/actions/checkout/pull/2224">actions/checkout#2224</a></li>
<li>Update package dependencies by <a
href="https://github.com/salmanmkc"><code>@​salmanmkc</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/2236">actions/checkout#2236</a></li>
</ul>
<h2>v4.2.2</h2>
<ul>
<li><code>url-helper.ts</code> now leverages well-known environment
variables by <a href="https://github.com/jww3"><code>@​jww3</code></a>
in <a
href="https://redirect.github.com/actions/checkout/pull/1941">actions/checkout#1941</a></li>
<li>Expand unit test coverage for <code>isGhes</code> by <a
href="https://github.com/jww3"><code>@​jww3</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1946">actions/checkout#1946</a></li>
</ul>
<h2>v4.2.1</h2>
<ul>
<li>Check out other refs/* by commit if provided, fall back to ref by <a
href="https://github.com/orhantoy"><code>@​orhantoy</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1924">actions/checkout#1924</a></li>
</ul>
<h2>v4.2.0</h2>
<ul>
<li>Add Ref and Commit outputs by <a
href="https://github.com/lucacome"><code>@​lucacome</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1180">actions/checkout#1180</a></li>
<li>Dependency updates by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>- <a
href="https://redirect.github.com/actions/checkout/pull/1777">actions/checkout#1777</a>,
<a
href="https://redirect.github.com/actions/checkout/pull/1872">actions/checkout#1872</a></li>
</ul>
<h2>v4.1.7</h2>
<ul>
<li>Bump the minor-npm-dependencies group across 1 directory with 4
updates by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1739">actions/checkout#1739</a></li>
<li>Bump actions/checkout from 3 to 4 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1697">actions/checkout#1697</a></li>
<li>Check out other refs/* by commit by <a
href="https://github.com/orhantoy"><code>@​orhantoy</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1774">actions/checkout#1774</a></li>
<li>Pin actions/checkout's own workflows to a known, good, stable
version. by <a href="https://github.com/jww3"><code>@​jww3</code></a> in
<a
href="https://redirect.github.com/actions/checkout/pull/1776">actions/checkout#1776</a></li>
</ul>
<h2>v4.1.6</h2>
<ul>
<li>Check platform to set archive extension appropriately by <a
href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in
<a
href="https://redirect.github.com/actions/checkout/pull/1732">actions/checkout#1732</a></li>
</ul>
<h2>v4.1.5</h2>
<ul>
<li>Update NPM dependencies by <a
href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in
<a
href="https://redirect.github.com/actions/checkout/pull/1703">actions/checkout#1703</a></li>
<li>Bump github/codeql-action from 2 to 3 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1694">actions/checkout#1694</a></li>
<li>Bump actions/setup-node from 1 to 4 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1696">actions/checkout#1696</a></li>
<li>Bump actions/upload-artifact from 2 to 4 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1695">actions/checkout#1695</a></li>
<li>README: Suggest <code>user.email</code> to be
<code>41898282+github-actions[bot]@users.noreply.github.com</code> by <a
href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in
<a
href="https://redirect.github.com/actions/checkout/pull/1707">actions/checkout#1707</a></li>
</ul>
<h2>v4.1.4</h2>
<ul>
<li>Disable <code>extensions.worktreeConfig</code> when disabling
<code>sparse-checkout</code> by <a
href="https://github.com/jww3"><code>@​jww3</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1692">actions/checkout#1692</a></li>
<li>Add dependabot config by <a
href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in
<a
href="https://redirect.github.com/actions/checkout/pull/1688">actions/checkout#1688</a></li>
<li>Bump the minor-actions-dependencies group with 2 updates by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1693">actions/checkout#1693</a></li>
<li>Bump word-wrap from 1.2.3 to 1.2.5 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/actions/checkout/pull/1643">actions/checkout#1643</a></li>
</ul>
<h2>v4.1.3</h2>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/actions/checkout/commit/08c6903cd8c0fde910a37f88322edcfb5dd907a8"><code>08c6903</code></a>
Prepare v5.0.0 release (<a
href="https://redirect.github.com/actions/checkout/issues/2238">#2238</a>)</li>
<li><a
href="https://github.com/actions/checkout/commit/9f265659d3bb64ab1440b03b12f4d47a24320917"><code>9f26565</code></a>
Update actions checkout to use node 24 (<a
href="https://redirect.github.com/actions/checkout/issues/2226">#2226</a>)</li>
<li>See full diff in <a
href="https://github.com/actions/checkout/compare/v4...v5">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/checkout&package-manager=github_actions&previous-version=4&new-version=5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…17371)

This PR updates the handling of the Node SDK of incoming requests.
Instead of relying on @opentelemetry/instrumentation-http for this, we
now handle this internally, ensuring that we can optimize performance as
much as possible and avoid interop problems. This will also allow us to
extract this out of an OTEL instrumentation, eventually paving the way
for a non-OTEL SDK with basic tracing capabilities.

This change should not affect users, unless they are relying on very
in-depth implementation details. Importantly, this also drops the
`_experimentalConfig` option of the integration - this will no longer do
anything.
Finally, you can still pass
`instrumentation.{requestHook,responseHook,applyCustomAttributesOnSpan}`
options, but they are deprecated and will be removed in v11. Instead,
you can use the new `incomingRequestSpanHook` configuration option if
you want to adjust the incoming request span.

I have tried to ensure the spans look as similar as possible as before,
this should be reflected in the tests.

---------

Co-authored-by: Lukas Stracke <[email protected]>
#17497 probably
accidentally removed our changelog script.
@andreiborza andreiborza requested a review from a team as a code owner September 3, 2025 11:48
CHANGELOG.md Outdated

This version updates the handling of the Node SDK of incoming requests. Instead of relying on @opentelemetry/instrumentation-http, we now handle incoming request instrumentation internally, ensuring that we can optimize performance as much as possible and avoid interop problems.

This change should not affect users, unless they are relying on very in-depth implementation details. Importantly, this also drops the `_experimentalConfig` option of the integration - this will no longer do anything.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This change should not affect users, unless they are relying on very in-depth implementation details. Importantly, this also drops the `_experimentalConfig` option of the integration - this will no longer do anything.
This change should not you, unless you're relying on very in-depth implementation details. Importantly, this also drops the `_experimentalConfig` option of the integration - this will no longer do anything.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks!

Copy link
Contributor

github-actions bot commented Sep 3, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.16 kB added added
@sentry/browser - with treeshaking flags 22.73 kB added added
@sentry/browser (incl. Tracing) 39.87 kB added added
@sentry/browser (incl. Tracing, Replay) 78.23 kB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 68.02 kB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 82.91 kB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 95.04 kB added added
@sentry/browser (incl. Feedback) 40.83 kB added added
@sentry/browser (incl. sendFeedback) 28.81 kB added added
@sentry/browser (incl. FeedbackAsync) 33.7 kB added added
@sentry/react 25.88 kB added added
@sentry/react (incl. Tracing) 41.89 kB added added
@sentry/vue 28.64 kB added added
@sentry/vue (incl. Tracing) 41.69 kB added added
@sentry/svelte 24.18 kB added added
CDN Bundle 25.66 kB added added
CDN Bundle (incl. Tracing) 39.75 kB added added
CDN Bundle (incl. Tracing, Replay) 76.03 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 81.47 kB added added
CDN Bundle - uncompressed 74.96 kB added added
CDN Bundle (incl. Tracing) - uncompressed 117.59 kB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 232.69 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 245.31 kB added added
@sentry/nextjs (client) 43.89 kB added added
@sentry/sveltekit (client) 40.33 kB added added
@sentry/node-core 49.61 kB added added
@sentry/node 150.26 kB added added
@sentry/node - without tracing 92.19 kB added added
@sentry/aws-serverless 105.48 kB added added

Copy link
Contributor

github-actions bot commented Sep 3, 2025

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 9,113 - - added
GET With Sentry 1,289 14% - added
GET With Sentry (error only) 6,113 67% - added
POST Baseline 1,213 - - added
POST With Sentry 486 40% - added
POST With Sentry (error only) 1,086 90% - added
MYSQL Baseline 3,356 - - added
MYSQL With Sentry 474 14% - added
MYSQL With Sentry (error only) 2,748 82% - added

@andreiborza andreiborza force-pushed the prepare-release/10.9.0 branch from 496ef76 to 10b5928 Compare September 3, 2025 12:08
@andreiborza andreiborza merged commit 143510b into master Sep 3, 2025
185 checks passed
@andreiborza andreiborza deleted the prepare-release/10.9.0 branch September 3, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants