feat(node): Use process.on('SIGTERM') for flushing in Vercel functions
#17583
Conversation
size-limit report 📦
|
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
| if (process.env.VERCEL) { | ||
| process.on('SIGTERM', async () => { | ||
| // We have 500ms for processing here, so we try to make sure to have enough time to send the events | ||
| await client.flush(200); |
There was a problem hiding this comment.
Did you test this on a vercel function? Generally makes sense but we could bump this more up I'd say?
There was a problem hiding this comment.
did not test this so far at all, maybe you can take this PR over when you have some time and properly test it. The reason I went with 200 here is because this is just the timeout used for finishing events, we still need time to actually make the http request so there needs to be some wiggle room -to the max. 500ms - if we spend 500ms on processing events, we have no more time to actually send the events 😅
There was a problem hiding this comment.
Ah yeah that makes sense I thought this time is included already, I'll take it over
2 participants
This adds a better way to ensure we flush in node-based vercel functions.
Note that this does not work in edge functions, so we need to keep the
vercelWaitUntilcode around for this - but we can noop it in node and instead rely on the better way to handle this, I believe.@chargome when you're back, can you verify if this makes sense? 😅
Closes #17567