Skip to content

ref(solidstart): Adjust event mechanism in withServerActionInstrumentation #17637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 16, 2025
Merged

ref(solidstart): Adjust event mechanism in withServerActionInstrumentation #17637

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4575601
ref(solidstart): Adjust mechanism in `withServerActionInstrumentation`
Lms24 Sep 15, 2025
7ed4567
changelog
Lms24 Sep 15, 2025
a9da4ed
Merge branch 'develop' into lms/ref-solidstart-mechanism
Lms24 Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
- ref(remix): Adjust event mechanism of `captureRemixServerException` ([#17629](https://github.com/getsentry/sentry-javascript/pull/17629))
- ref(replay-internal): Add mechanism to error caught by `replayIntegration` in debug mode ([#17606](https://github.com/getsentry/sentry-javascript/pull/17606))
- ref(solid): Add `mechanism` to error captured by `withSentryErrorBoundary` ([#17607](https://github.com/getsentry/sentry-javascript/pull/17607))
- ref(solidstart): Adjust event mechanism in withServerActionInstrumentation ([#17637](https://github.com/getsentry/sentry-javascript/pull/17637))

<br/>

Expand Down
2 changes: 1 addition & 1 deletion ...ackages/e2e-tests/test-applications/solidstart-dynamic-import/tests/errors.server.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ test.describe('server-side errors', () => {
type: 'Error',
value: 'Error thrown from Solid Start E2E test app server route',
mechanism: {
type: 'solidstart',
type: 'auto.function.solidstart',
handled: false,
},
},
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/solidstart-spa/tests/errors.server.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ test.describe('server-side errors', () => {
type: 'Error',
value: 'Error thrown from Solid Start E2E test app server route',
mechanism: {
type: 'solidstart',
type: 'auto.function.solidstart',
handled: false,
},
},
Expand Down
2 changes: 1 addition & 1 deletion ...kages/e2e-tests/test-applications/solidstart-top-level-import/tests/errors.server.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ test.describe('server-side errors', () => {
type: 'Error',
value: 'Error thrown from Solid Start E2E test app server route',
mechanism: {
type: 'solidstart',
type: 'auto.function.solidstart',
handled: false,
},
},
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/solidstart/tests/errors.server.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ test.describe('server-side errors', () => {
type: 'Error',
value: 'Error thrown from Solid Start E2E test app server route',
mechanism: {
type: 'solidstart',
type: 'auto.function.solidstart',
handled: false,
},
},
Expand Down
2 changes: 1 addition & 1 deletion packages/solidstart/src/server/withServerActionInstrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export async function withServerActionInstrumentation<A extends (...args: unknow
captureException(error, {
mechanism: {
handled: false,
type: 'solidstart',
type: 'auto.function.solidstart',
},
});
}
Expand Down
4 changes: 3 additions & 1 deletion packages/solidstart/test/server/withServerActionInstrumentation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,9 @@ describe('withServerActionInstrumentation', () => {
await expect(res).rejects.toThrow();

expect(mockCaptureException).toHaveBeenCalledTimes(1);
expect(mockCaptureException).toHaveBeenCalledWith(error, { mechanism: { handled: false, type: 'solidstart' } });
expect(mockCaptureException).toHaveBeenCalledWith(error, {
mechanism: { handled: false, type: 'auto.function.solidstart' },
});
});

it("doesn't call captureException for thrown redirects", async () => {
Expand Down