Skip to content

fix(core): Fix error handling when sending envelopes #17662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 16, 2025
Merged

fix(core): Fix error handling when sending envelopes #17662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e40a66d
fix(core): Fix error handling when sending envelopes
mydea Sep 16, 2025
a008c7b
less changes
mydea Sep 16, 2025
42bc9f0
small ref
mydea Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions packages/core/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,10 +415,9 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
env = addItemToEnvelope(env, createAttachmentEnvelopeItem(attachment));
}

const promise = this.sendEnvelope(env);
if (promise) {
promise.then(sendResponse => this.emit('afterSendEvent', event, sendResponse), null);
}
// sendEnvelope should not throw
// eslint-disable-next-line @typescript-eslint/no-floating-promises
this.sendEnvelope(env).then(sendResponse => this.emit('afterSendEvent', event, sendResponse));
}

/**
Expand Down Expand Up @@ -879,12 +878,11 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
if (this._isEnabled() && this._transport) {
return this._transport.send(envelope).then(null, reason => {
DEBUG_BUILD && debug.error('Error while sending envelope:', reason);
return reason;
return {};
});
}

DEBUG_BUILD && debug.error('Transport disabled');

return resolvedSyncPromise({});
}

Expand Down
2 changes: 1 addition & 1 deletion packages/core/test/lib/client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2268,7 +2268,7 @@ describe('Client', () => {

expect(mockSend).toBeCalledTimes(1);
expect(callback).toBeCalledTimes(1);
expect(callback).toBeCalledWith(errorEvent, 'send error');
expect(callback).toBeCalledWith(errorEvent, {});
});

it('passes the response to the hook', async () => {
Expand Down
5 changes: 2 additions & 3 deletions packages/replay-internal/src/coreHandlers/handleAfterSendEvent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,10 @@ export function handleAfterSendEvent(replay: ReplayContainer): AfterSendEventCal
return;
}

const statusCode = sendResponse?.statusCode;
const statusCode = sendResponse.statusCode;

// We only want to do stuff on successful error sending, otherwise you get error replays without errors attached
// If not using the base transport, we allow `undefined` response (as a custom transport may not implement this correctly yet)
// If we do use the base transport, we skip if we encountered an non-OK status code
// We skip if we encountered an non-OK status code
if (!statusCode || statusCode < 200 || statusCode >= 300) {
return;
}
Expand Down
Loading