fix(node): Fix this context for vercel AI instrumentation
#17681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
RulaKhaled
approved these changes
Sep 17, 2025
mydea
added a commit
that referenced
this pull request
Sep 17, 2025
I've seen a few places where we are wrapping things that could be sync
or async, and we want to do something with the return value. By adding
an onSuccess handler to `handelCallbackErrors` we can handle this more
generically in the future:
```js
const wrapped = handleCallbackErrors(
() => fn(),
// error handler
(_err) => {},
// finally handler
() => {},
// success handler, gets value or resolved value if function returns a promise
(_value) => {}
);
```
While scanning a bit for places where we could already use this, I also
found two bugs around this, opened separate PRs for them:
* #17680
* #17681
This was referenced Sep 29, 2025
This was referenced Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while working on #17679, we incorrectly changed the
thiscontext here (which is also why TS complained).I rewrote this to a proxy which should keep the context properly.