Skip to content

build: Update TS target to es2020 everywhere #17709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2025
Merged

build: Update TS target to es2020 everywhere #17709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d6bc4d
build: Update TS target to `es2020` everywhere
mydea Sep 22, 2025
96b9292
fix cloudflare types
mydea Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev-packages/browser-integration-tests/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"extends": "../../tsconfig.json",

"compilerOptions": {
"lib": ["dom", "es2019"],
"lib": ["dom", "ES2020"],
"moduleResolution": "node",
"noEmit": true,
"strict": true,
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/cloudflare-integration-tests/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"@sentry/cloudflare": "10.14.0"
},
"devDependencies": {
"@cloudflare/workers-types": "^4.20250708.0",
"@cloudflare/workers-types": "^4.20250922.0",
"@sentry-internal/test-utils": "10.14.0",
"vitest": "^3.2.4",
"wrangler": "4.22.0"
Expand Down
3 changes: 2 additions & 1 deletion dev-packages/cloudflare-integration-tests/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
// Although this seems wrong to include `DOM` here, it's necessary to make
// global fetch available in tests in lower Node versions.
"lib": ["ES2020"],
"esModuleInterop": true
"esModuleInterop": true,
"types": ["@cloudflare/workers-types"]
}
}
2 changes: 1 addition & 1 deletion dev-packages/node-core-integration-tests/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"compilerOptions": {
// Although this seems wrong to include `DOM` here, it's necessary to make
// global fetch available in tests in lower Node versions.
"lib": ["DOM", "ES2018"],
"lib": ["DOM", "es2020"],
// package-specific options
"esModuleInterop": true,
"types": ["node"]
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/node-core-integration-tests/tsconfig.test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"compilerOptions": {
// Although this seems wrong to include `DOM` here, it's necessary to make
// global fetch available in tests in lower Node versions.
"lib": ["DOM", "ES2018"],
"lib": ["DOM", "es2020"],
// should include all types from `./tsconfig.json` plus types for all test frameworks used
"types": ["node"]

Expand Down
2 changes: 1 addition & 1 deletion dev-packages/node-integration-tests/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"compilerOptions": {
// Although this seems wrong to include `DOM` here, it's necessary to make
// global fetch available in tests in lower Node versions.
"lib": ["DOM", "ES2018"],
"lib": ["DOM", "es2020"],
// package-specific options
"esModuleInterop": true,
"types": ["node"]
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/node-integration-tests/tsconfig.test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"compilerOptions": {
// Although this seems wrong to include `DOM` here, it's necessary to make
// global fetch available in tests in lower Node versions.
"lib": ["DOM", "ES2018"],
"lib": ["DOM", "es2020"],
// should include all types from `./tsconfig.json` plus types for all test frameworks used
"types": ["node"]

Expand Down
4 changes: 2 additions & 2 deletions packages/angular/tsconfig.ngc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
{
"extends": "./tsconfig.json",
"compilerOptions": {
"target": "es2018",
"target": "es2020",
"declarationMap": false,
"lib": ["DOM", "ES2018"],
"lib": ["DOM", "es2020"],
Comment on lines +8 to +10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! Turns out we could have done this a lot sooner for Angular, ever since we switched to NG14 as the min version (https://v14.angular.io/guide/angular-package-format#es2020-language-level).

"baseUrl": "./"
},
"angularCompilerOptions": {
Expand Down
2 changes: 1 addition & 1 deletion packages/aws-serverless/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

"compilerOptions": {
// package-specific options
"target": "ES2018",
"target": "es2020",
"resolveJsonModule": true
}
}
2 changes: 1 addition & 1 deletion packages/browser-utils/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
"include": ["src/**/*"],

"compilerOptions": {
"lib": ["DOM", "ES2018"]
"lib": ["DOM", "es2020"]
}
}
2 changes: 1 addition & 1 deletion packages/browser/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
"include": ["src/**/*", "test/loader.js"],

"compilerOptions": {
"lib": ["DOM", "ES2018", "WebWorker"]
"lib": ["DOM", "es2020", "WebWorker"]
}
}
2 changes: 1 addition & 1 deletion packages/cloudflare/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
}
},
"devDependencies": {
"@cloudflare/workers-types": "4.20250620.0",
"@cloudflare/workers-types": "4.20250922.0",
"@types/node": "^18.19.1",
"wrangler": "4.22.0"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/core/tsconfig.test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"include": ["test/**/*", "vite.config.ts"],

"compilerOptions": {
"lib": ["DOM", "ES2018"],
"lib": ["DOM", "es2020"],
"module": "ESNext", // support dynamic import()
// should include all types from `./tsconfig.json` plus types for all test frameworks used
"types": ["node"]
Expand Down
2 changes: 1 addition & 1 deletion packages/gatsby/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"include": ["src/**/*"],

"compilerOptions": {
"lib": ["DOM", "ES2018"],
"lib": ["DOM", "es2020"],
// package-specific options
"jsx": "react"
}
Expand Down
2 changes: 1 addition & 1 deletion packages/google-cloud-serverless/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

"compilerOptions": {
// package-specific options
"target": "ES2018",
"target": "es2020",
"resolveJsonModule": true
}
}
2 changes: 1 addition & 1 deletion packages/nextjs/tsconfig.test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

// require for top-level await
"module": "Node16",
"target": "es2017",
"target": "es2020",

// other package-specific, test-specific options
"lib": ["DOM", "ESNext"]
Expand Down
2 changes: 1 addition & 1 deletion packages/node-core/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"include": ["src/**/*"],

"compilerOptions": {
"lib": ["es2018", "es2020.string"],
"lib": ["es2020"],
"module": "Node16"
}
}
2 changes: 1 addition & 1 deletion packages/node-native/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"extends": "../../tsconfig.json",
"compilerOptions": {
"module": "esnext",
"lib": ["es2018"],
"lib": ["es2020"],
"outDir": "build",
"types": ["node"]
},
Expand Down
2 changes: 1 addition & 1 deletion packages/node/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"include": ["src/**/*"],

"compilerOptions": {
"lib": ["es2018", "es2020.string"],
"lib": ["es2020"],
"module": "Node16"
}
}
2 changes: 1 addition & 1 deletion packages/pino-transport/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"include": ["src/**/*"],

"compilerOptions": {
"lib": ["es2018", "es2020.string"],
"lib": ["es2020"],
"module": "Node16"
}
}
2 changes: 1 addition & 1 deletion packages/profiling-node/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"extends": "../../tsconfig.json",
"compilerOptions": {
"module": "esnext",
"lib": ["es2018"],
"lib": ["es2020"],
"outDir": "build",
"types": ["node"]
},
Expand Down
2 changes: 1 addition & 1 deletion packages/react/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"include": ["src/**/*"],

"compilerOptions": {
"lib": ["DOM", "ES2018"],
"lib": ["DOM", "es2020"],
// package-specific options
"esModuleInterop": true,
"jsx": "react"
Expand Down
4 changes: 2 additions & 2 deletions packages/remix/test/integration/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{
"include": ["remix.env.d.ts", "**/*.ts", "**/*.tsx"],
"compilerOptions": {
"lib": ["DOM", "DOM.Iterable", "ES2019"],
"lib": ["DOM", "DOM.Iterable", "ES2020"],
"isolatedModules": true,
"esModuleInterop": true,
"jsx": "react-jsx",
"moduleResolution": "node",
"resolveJsonModule": true,
"target": "ES2019",
"target": "es2020",
"strict": true,
"allowJs": true,
"forceConsistentCasingInFileNames": true,
Expand Down
4 changes: 2 additions & 2 deletions packages/remix/tsconfig.test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@
"include": ["test/**/*", "vitest.config.ts", "vitest.config.unit.ts"],

"compilerOptions": {
"lib": ["DOM", "ES2018"],
"lib": ["DOM", "es2020"],
"types": ["node"],
// Required for top-level await in tests
"module": "Node16",
"target": "ES2017",
"target": "es2020",

"esModuleInterop": true
}
Expand Down
2 changes: 1 addition & 1 deletion packages/replay-canvas/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"extends": "../../tsconfig.json",
"compilerOptions": {
"lib": ["DOM", "ES2018"],
"lib": ["DOM", "es2020"],
"module": "esnext"
},
"include": ["src/**/*.ts"]
Expand Down
2 changes: 1 addition & 1 deletion packages/replay-canvas/tsconfig.test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"include": ["test/**/*.ts", "vite.config.ts"],

"compilerOptions": {
"lib": ["DOM", "ES2018"],
"lib": ["DOM", "es2020"],
"types": ["node"],
"esModuleInterop": true,
"allowJs": true,
Expand Down
2 changes: 1 addition & 1 deletion packages/replay-internal/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"extends": "../../tsconfig.json",
"compilerOptions": {
"lib": ["DOM", "ES2018"],
"lib": ["DOM", "es2020"],
"module": "esnext"
},
"include": ["src/**/*.ts"]
Expand Down
2 changes: 1 addition & 1 deletion packages/replay-worker/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"module": "esnext",
"lib": ["webworker", "scripthost"],
"esModuleInterop": true,
"target": "es2018",
"target": "es2020",
"strictPropertyInitialization": false
},
"include": ["src/**/*.ts"]
Expand Down
2 changes: 1 addition & 1 deletion packages/solid/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
"include": ["src/**/*"],

"compilerOptions": {
"lib": ["DOM", "ES2018"]
"lib": ["DOM", "es2020"]
}
}
2 changes: 1 addition & 1 deletion packages/svelte/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
"include": ["src/**/*"],

"compilerOptions": {
"lib": ["DOM", "ES2018"]
"lib": ["DOM", "es2020"]
}
}
2 changes: 1 addition & 1 deletion packages/tanstackstart-react/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"extends": "../../tsconfig.json",
"include": ["src/**/*"],
"compilerOptions": {
"lib": ["es2018", "es2020.string"],
"lib": ["es2020"],
"module": "Node16"
}
}
2 changes: 1 addition & 1 deletion packages/tanstackstart/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"extends": "../../tsconfig.json",
"include": ["src/**/*"],
"compilerOptions": {
"lib": ["es2018", "es2020.string"],
"lib": ["es2020"],
"module": "Node16"
}
}
2 changes: 1 addition & 1 deletion packages/types/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
"include": ["src/**/*"],

"compilerOptions": {
"lib": ["es2018"]
"lib": ["es2020"]
}
}
4 changes: 2 additions & 2 deletions packages/typescript/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"importHelpers": true,
"inlineSources": true,
"isolatedModules": true,
"lib": ["ES2018"],
"lib": ["es2020"],
"moduleResolution": "node",
"noErrorTruncation": true,
"noFallthroughCasesInSwitch": true,
Expand All @@ -18,7 +18,7 @@
"sourceMap": true,
"strict": true,
"strictBindCallApply": false,
"target": "es2018",
"target": "es2020",
"noUncheckedIndexedAccess": true
}
}
2 changes: 1 addition & 1 deletion packages/vercel-edge/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
// Note: using `dom` here is inaccurate for the vercel-edge runtime, but needed
// because @edge-runtime/types does not type things like fetch or RequestInit
// ref: https://github.com/vercel/edge-runtime/issues/506
"lib": ["DOM", "ES2018"],
"lib": ["DOM", "es2020"],
"types": ["@edge-runtime/types"]
}
}
2 changes: 1 addition & 1 deletion packages/vue/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
"include": ["src/**/*"],

"compilerOptions": {
"lib": ["DOM", "ES2018"]
"lib": ["DOM", "es2020"]
}
}
2 changes: 1 addition & 1 deletion packages/wasm/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
"include": ["src/**/*"],

"compilerOptions": {
"lib": ["DOM", "ES2018"]
"lib": ["DOM", "es2020"]
}
}
13 changes: 4 additions & 9 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2701,15 +2701,10 @@
resolved "https://registry.yarnpkg.com/@cloudflare/workerd-windows-64/-/workerd-windows-64-1.20250617.0.tgz#6b4397fcf01c7b8a547152761cc3bcd63e173a58"
integrity sha512-XWM/6sagDrO0CYDKhXhPjM23qusvIN1ju9ZEml6gOQs8tNOFnq6Cn6X9FAmnyapRFCGUSEC3HZYJAm7zwVKaMA==

"@cloudflare/[email protected]":
version "4.20250620.0"
resolved "https://registry.yarnpkg.com/@cloudflare/workers-types/-/workers-types-4.20250620.0.tgz#a22e635a631212963b84e315191614b20c4ad317"
integrity sha512-EVvRB/DJEm6jhdKg+A4Qm4y/ry1cIvylSgSO3/f/Bv161vldDRxaXM2YoQQWFhLOJOw0qtrHsKOD51KYxV1XCw==

"@cloudflare/workers-types@^4.20250708.0":
version "4.20250726.0"
resolved "https://registry.yarnpkg.com/@cloudflare/workers-types/-/workers-types-4.20250726.0.tgz#2bcd78bc5e26aa222d4a8f8cf9edb8f5f3427bb3"
integrity sha512-NtM1yVBKJFX4LgSoZkVU0EDhWWvSb1vt6REO+uMYZRgx1HAfQz9GDN6bBB0B+fm2ZIxzt6FzlDbmrXpGJ2M/4Q==
"@cloudflare/[email protected]", "@cloudflare/workers-types@^4.20250922.0":
version "4.20250922.0"
resolved "https://registry.yarnpkg.com/@cloudflare/workers-types/-/workers-types-4.20250922.0.tgz#a159fbf3bb785fa85b473ecfaa8c501525827885"
integrity sha512-BaqlKnVc0Xzqm9xt3TC4v0yB9EHy5vVqpiWz+DAsbEmdcpUbqdBschvI9502p6FgFbZElD7XcxTEeViXLsoO0A==

"@cnakazawa/watch@^1.0.3":
version "1.0.4"
Expand Down