Skip to content

Conversation

mydea
Copy link
Member

@mydea mydea commented Sep 19, 2025

This updates the TS version we use to 5.8.0.

We still downlevel to 3.8 so this should not be breaking (even if we were to use newer features eventually), downlevel-dts will fail/or our tests anyhow if we use some features that cannot be downlevelled.


Note

Upgrade TypeScript to 5.8 across the repo, adjust tsconfigs and deps, and fix minor type issues to satisfy stricter checks.

  • Tooling/Versions:
    • Bump typescript to ~5.8.0 and update version guard in scripts/verify-packages-versions.js.
    • Update yarn.lock and package constraints; add new e2e app dev-packages/e2e-tests/test-applications/generic-ts5.0.
  • TS Configs:
    • Add moduleResolution: "Node16" in multiple tsconfig.json files and test configs.
    • Add @types/node and include "node" in types where needed (e.g., Hydrogen test app).
  • Type/Code Adjustments:
    • Remove unnecessary casts and add explicit non-null assertions for Map.keys().next().value.
    • Simplify handler registration (handlers[type].push(handler)), and minor TS cleanups in profiling/LRU/debug-id utilities.
    • Cloudflare/Nuxt/SvelteKit: relax Request typing and use @ts-expect-error for cf init property; avoid unused CF type import.
    • Next.js webpack: remove unnecessary non-null assertion when joining appDirPath.
    • Remix: streamline FormData attribute handling and vendor instrumentation check.

Written by Cursor Bugbot for commit 5ec5959. This will update automatically on new commits. Configure here.

@mydea mydea self-assigned this Sep 19, 2025
Copy link
Contributor

github-actions bot commented Sep 22, 2025

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 9,005 - 9,344 -4%
GET With Sentry 1,430 16% 1,412 +1%
GET With Sentry (error only) 6,254 69% 6,130 +2%
POST Baseline 1,214 - 1,211 +0%
POST With Sentry 528 43% 509 +4%
POST With Sentry (error only) 1,074 88% 1,069 +0%
MYSQL Baseline 3,348 - 3,221 +4%
MYSQL With Sentry 498 15% 370 +35%
MYSQL With Sentry (error only) 2,752 82% 2,625 +5%

View base workflow run

@mydea mydea force-pushed the fn/bump-ts branch 2 times, most recently from 17e7562 to fa8a726 Compare September 23, 2025 14:33
@mydea mydea marked this pull request as ready for review September 24, 2025 07:16
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to adjust

  "typesVersions": {
    "<5.0": {
      "build/npm/types/index.d.ts": [
        "build/npm/types-ts3.8/index.d.ts"
      ]
    }
  },

in package.json? Unless I'm missing something, users using e.g. TS 5.2 would not get the downleveled types but might run into issues with newer TS version syntax.

@mydea
Copy link
Member Author

mydea commented Sep 24, 2025

Don't we need to adjust

  "typesVersions": {
    "<5.0": {
      "build/npm/types/index.d.ts": [
        "build/npm/types-ts3.8/index.d.ts"
      ]
    }
  },

in package.json? Unless I'm missing something, users using e.g. TS 5.2 would not get the downleveled types but might run into issues with newer TS version syntax.

Yeah, you are right I suppose! Will adjust this 👍

@mydea mydea requested review from a team as code owners September 24, 2025 11:12
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, forgot to ✅

@s1gr1d s1gr1d merged commit 55f03e0 into develop Oct 17, 2025
375 of 377 checks passed
@s1gr1d s1gr1d deleted the fn/bump-ts branch October 17, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants