Conversation
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
17e7562 to
fa8a726
Compare
andreiborza
reviewed
Sep 24, 2025
Lms24
reviewed
Sep 24, 2025
Member
There was a problem hiding this comment.
Don't we need to adjust
"typesVersions": {
"<5.0": {
"build/npm/types/index.d.ts": [
"build/npm/types-ts3.8/index.d.ts"
]
}
},
in package.json? Unless I'm missing something, users using e.g. TS 5.2 would not get the downleveled types but might run into issues with newer TS version syntax.
Member
Author
Yeah, you are right I suppose! Will adjust this 👍 |
andreiborza
approved these changes
Sep 24, 2025
s1gr1d
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the TS version we use to 5.8.0.
We still downlevel to 3.8 so this should not be breaking (even if we were to use newer features eventually), downlevel-dts will fail/or our tests anyhow if we use some features that cannot be downlevelled.
Note
Upgrade TypeScript to 5.8 across the repo, adjust tsconfigs and deps, and fix minor type issues to satisfy stricter checks.
typescriptto~5.8.0and update version guard inscripts/verify-packages-versions.js.yarn.lockand package constraints; add new e2e appdev-packages/e2e-tests/test-applications/generic-ts5.0.moduleResolution: "Node16"in multipletsconfig.jsonfiles and test configs.@types/nodeand include"node"intypeswhere needed (e.g., Hydrogen test app).Map.keys().next().value.handlers[type].push(handler)), and minor TS cleanups in profiling/LRU/debug-id utilities.@ts-expect-errorforcfinit property; avoid unused CF type import.appDirPath.Written by Cursor Bugbot for commit 5ec5959. This will update automatically on new commits. Configure here.