fix(react): Do not send additional navigation span on pageload #17799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
approved these changes
Sep 26, 2025
onurtemizkan
approved these changes
Sep 29, 2025
This was referenced Sep 29, 2025
andreiborza
pushed a commit
to thedanchez/sentry-javascript
that referenced
this pull request
Oct 15, 2025
…ntry#17799) The React Router instrumentation created an additional `navigation` span on `pageload`. On initial load, the lazy route has the history action `POP` and state `idle`. This leads to the generation of a `navigation` span. I added a condition to early-return from `handleNavigation` if a page load is going on. Closes issue (in Linear) https://linear.app/getsentry/issue/FE-551/configure-react-router-for-fully-parameterized-routes-with-sentry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The React Router instrumentation created an additional
navigationspan onpageload.On initial load, the lazy route has the history action
POPand stateidle. This leads to the generation of anavigationspan.I added a condition to early-return from
handleNavigationif a page load is going on.Closes issue (in Linear) https://linear.app/getsentry/issue/FE-551/configure-react-router-for-fully-parameterized-routes-with-sentry