fix(aws-serverless): Take http_proxy into account when choosing useLayerExtension default
#17817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreiborza
force-pushed
the
ab/aws-handle-http-proxy
branch
from
fabe4f6 to
0caed0c
Compare
size-limit report 📦
|
`useLayerExtension` default The default setting for `useLayerExtension` now considers the `http_proxy` environment variable. When `http_proxy` is set, `useLayerExtension` will be off by default. If you use a `http_proxy` but would still like to make use of the Sentry Lambda extension, exempt `localhost` in a `no_proxy` environment variable. Fixes: #17804
andreiborza
force-pushed
the
ab/aws-handle-http-proxy
branch
from
0caed0c to
53e333f
Compare
Closed
3 tasks
This was referenced Sep 30, 2025
andreiborza
added a commit
to thedanchez/sentry-javascript
that referenced
this pull request
Oct 15, 2025
…eLayerExtension` default (getsentry#17817) The default setting for `useLayerExtension` now considers the `http_proxy` environment variable. When `http_proxy` is set, `useLayerExtension` will be off by default. If you use a `http_proxy` but would still like to make use of the Sentry Lambda extension, exempt `localhost` in a `no_proxy` environment variable. Fixes: getsentry#17804 <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Disable `useLayerExtension` by default when `http_proxy` is set (unless `no_proxy` exempts localhost), add debug warnings, tests, and changelog entry. > > - **aws-serverless**: > - Consider proxy env vars when defaulting `useLayerExtension` in `packages/aws-serverless/src/init.ts`. > - New `shouldDisableLayerExtensionForProxy()` checks `http_proxy` and `no_proxy` (localhost exemptions). > - Update default: enable only if using Lambda layer, no custom tunnel, and no proxy interference. > - Add debug warnings when disabling due to proxy and when tunneling via extension. > - **Tests**: > - Expand `packages/aws-serverless/test/init.test.ts` to cover proxy/no_proxy scenarios, explicit overrides, and env cleanup. > - **Docs/Changelog**: > - Add Important Changes note explaining new default behavior and how to re-enable with `no_proxy` exemptions. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 53e333f. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default setting for
useLayerExtensionnow considers thehttp_proxyenvironment variable. Whenhttp_proxyis set,useLayerExtensionwill be off by default. If you use ahttp_proxybut would still like to make use of the Sentry Lambda extension, exemptlocalhostin ano_proxyenvironment variable.Fixes: #17804
Note
Disable
useLayerExtensionby default whenhttp_proxyis set (unlessno_proxyexempts localhost), add debug warnings, tests, and changelog entry.useLayerExtensioninpackages/aws-serverless/src/init.ts.shouldDisableLayerExtensionForProxy()checkshttp_proxyandno_proxy(localhost exemptions).packages/aws-serverless/test/init.test.tsto cover proxy/no_proxy scenarios, explicit overrides, and env cleanup.no_proxyexemptions.Written by Cursor Bugbot for commit 53e333f. This will update automatically on new commits. Configure here.