Skip to content

ci(deps): Bump actions/setup-node from 4 to 5 #17824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+27 −27
Open

ci(deps): Bump actions/setup-node from 4 to 5 #17824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/auto-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
echo "version=$version" >> $GITHUB_OUTPUT

- name: Set up Node
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version-file: 'package.json'

Expand Down
40 changes: 20 additions & 20 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ jobs:
ref: ${{ env.HEAD_COMMIT }}

- name: Set up Node
uses: actions/setup-node@v4
uses: actions/setup-node@v5
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Node Setup v5 Cache Conflict

The upgrade to actions/setup-node@v5 enables automatic dependency caching. This conflicts with our existing custom caching strategies across workflows and specifically contradicts the clear-cache.yml workflow's purpose of never storing caches.

Additional Locations (1)

Fix in Cursor Fix in Web

with:
node-version-file: 'package.json'

Expand Down Expand Up @@ -242,7 +242,7 @@ jobs:
with:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version-file: 'package.json'
- name: Restore caches
Expand Down Expand Up @@ -271,7 +271,7 @@ jobs:
with:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version-file: 'package.json'
- name: Restore caches
Expand Down Expand Up @@ -300,7 +300,7 @@ jobs:
with:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version-file: 'package.json'
- name: Restore caches
Expand Down Expand Up @@ -330,7 +330,7 @@ jobs:
ref: ${{ env.HEAD_COMMIT }}

- name: Set up Node
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version-file: 'package.json'

Expand All @@ -352,7 +352,7 @@ jobs:
with:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version-file: 'package.json'
- name: Restore caches
Expand All @@ -374,7 +374,7 @@ jobs:
with:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version-file: 'package.json'
- name: Restore caches
Expand Down Expand Up @@ -415,7 +415,7 @@ jobs:
with:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version-file: 'package.json'
- name: Restore caches
Expand Down Expand Up @@ -456,7 +456,7 @@ jobs:
with:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version-file: 'package.json'
- name: Set up Bun
Expand All @@ -481,7 +481,7 @@ jobs:
with:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version-file: 'package.json'
- name: Set up Deno
Expand Down Expand Up @@ -518,7 +518,7 @@ jobs:
with:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version: ${{ matrix.node }}
- name: Restore caches
Expand Down Expand Up @@ -607,7 +607,7 @@ jobs:
with:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version-file: 'package.json'
- name: Restore caches
Expand Down Expand Up @@ -671,7 +671,7 @@ jobs:
with:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version-file: 'package.json'
- name: Restore caches
Expand Down Expand Up @@ -719,7 +719,7 @@ jobs:
with:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version-file: 'package.json'
- name: Restore caches
Expand Down Expand Up @@ -757,7 +757,7 @@ jobs:
with:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version: ${{ matrix.node }}
- name: Restore caches
Expand Down Expand Up @@ -793,7 +793,7 @@ jobs:
with:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version-file: 'package.json'
- name: Restore caches
Expand Down Expand Up @@ -821,7 +821,7 @@ jobs:
with:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version: ${{ matrix.node }}
- name: Restore caches
Expand Down Expand Up @@ -873,7 +873,7 @@ jobs:
with:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version-file: 'package.json'
- name: Restore caches
Expand Down Expand Up @@ -941,7 +941,7 @@ jobs:
with:
version: 9.15.9
- name: Set up Node
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version-file: 'dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}/package.json'
- name: Set up Bun
Expand Down Expand Up @@ -1071,7 +1071,7 @@ jobs:
with:
version: 9.15.9
- name: Set up Node
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version-file: 'dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}/package.json'
- name: Restore caches
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/canary.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
with:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version-file: 'package.json'
- name: Check canary cache
Expand Down Expand Up @@ -125,7 +125,7 @@ jobs:
version: 9.15.9
- name: Set up Node
if: matrix.test-application != 'angular-20'
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version-file: 'dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}/package.json'

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/clear-cache.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- uses: actions/checkout@v5

- name: Set up Node
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version-file: 'package.json'

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/external-contributors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
steps:
- uses: actions/checkout@v5
- name: Set up Node
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version-file: 'package.json'

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/flaky-test-detector.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- name: Check out current branch
uses: actions/checkout@v5
- name: Set up Node
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version-file: 'package.json'
cache: 'yarn'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
token: ${{ steps.token.outputs.token }}
fetch-depth: 0
- name: Set up Node
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version-file: 'package.json'
- name: Prepare release
Expand Down
Loading