-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(nuxt): include sentry.client.config.ts
in nuxt app types
#17830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
logaretm
merged 4 commits into
develop
from
awad/js-988-nuxt-4-sentryclientconfigts-types
Sep 30, 2025
Merged
fix(nuxt): include sentry.client.config.ts
in nuxt app types
#17830
logaretm
merged 4 commits into
develop
from
awad/js-988-nuxt-4-sentryclientconfigts-types
Sep 30, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1gr1d
approved these changes
Sep 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🎉
3 tasks
This was referenced Oct 7, 2025
andreiborza
pushed a commit
to thedanchez/sentry-javascript
that referenced
this pull request
Oct 15, 2025
…ntry#17830) # What Fixes getsentry#17781 by adding the `sentry.config.client.ts` to the auto generated tsconfig by extending the types via the [`prepare:types` hook](https://nuxt.com/docs/4.x/guide/going-further/modules#adding-type-declarations). This allows `useRuntimeConfig` to be properly typed in the root `sentry.client.config.ts`, or where ever the client file is found. Not sure how this could be tested tho, since it is purely types. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adds a `prepare:types` hook to include the client Sentry config in Nuxt’s generated `tsconfig` for proper typing. > > - **Nuxt module (`packages/nuxt/src/module.ts`)**: > - **Types setup**: Add `prepare:types` hook to ensure `tsconfig.include` contains the relative path to the detected client Sentry config (`sentry.client.config.ts`), enabling proper typing (e.g., `useRuntimeConfig`) in root config files for Nuxt v4. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 4de6d43. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #17781 by adding the
sentry.config.client.ts
to the auto generated tsconfig by extending the types via theprepare:types
hook.This allows
useRuntimeConfig
to be properly typed in the rootsentry.client.config.ts
, or where ever the client file is found.Not sure how this could be tested tho, since it is purely types.
Note
Adds a
prepare:types
hook to include the client Sentry config in Nuxt’s generatedtsconfig
for proper typing.packages/nuxt/src/module.ts
):prepare:types
hook to ensuretsconfig.include
contains the relative path to the detected client Sentry config (sentry.client.config.ts
), enabling proper typing (e.g.,useRuntimeConfig
) in root config files for Nuxt v4.Written by Cursor Bugbot for commit 4de6d43. This will update automatically on new commits. Configure here.