Skip to content

fix(node-core): passthrough node-cron context #17835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+7 −3
Open

fix(node-core): passthrough node-cron context #17835

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/node-core/src/cron/node-cron.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@ export interface NodeCronOptions {
}

export interface NodeCron {
schedule: (cronExpression: string, callback: () => void, options: NodeCronOptions | undefined) => unknown;
schedule: (
cronExpression: string,
callback: (context?: unknown) => void,
options: NodeCronOptions | undefined,
) => unknown;
}

/**
Expand Down Expand Up @@ -44,14 +48,14 @@ export function instrumentNodeCron<T>(lib: Partial<NodeCron> & T): T {
throw new Error('Missing "name" for scheduled job. A name is required for Sentry check-in monitoring.');
}

const monitoredCallback = async (): Promise<void> => {
const monitoredCallback = async (...args: Parameters<typeof callback>): Promise<void> => {
return withMonitor(
name,
async () => {
// We have to manually catch here and capture the exception because node-cron swallows errors
// https://github.com/node-cron/node-cron/issues/399
try {
return await callback();
return await callback(...args);
} catch (e) {
captureException(e, {
mechanism: {
Expand Down
Loading