fix(nextjs): fix createRouteManifest with basePath #17838
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| } | ||
|
|
||
| const { dynamicRoutes, staticRoutes } = scanAppDirectory(targetDir, '', options?.includeRouteGroups); | ||
| const { dynamicRoutes, staticRoutes } = scanAppDirectory(targetDir, options?.basePath, options?.includeRouteGroups); |
There was a problem hiding this comment.
Bug: Route Manifest Cache and Base Path Handling
The createRouteManifest cache doesn't invalidate when the basePath option changes, leading to stale manifests with incorrect route prefixes. Also, passing options?.basePath directly to scanAppDirectory can prefix routes with 'undefined/' when basePath is not provided.
|
Looks good already, would you mind also reflecting this in one of the e2e-tests ( |
If I apply a basePath to the existing E2E test application, it seems that all transaction assertions and URL paths in the test code would need to include the basePath prefix. Could you provide some guidance on whether it would be better to add tests directly to the existing app, or to create a separate app with basePath enabled for testing purposes? |
|
We can move this into a new next-15-basepath test. Feel free to ping me if I should take this over! |
fix #17837
add basePath prefix to createRouteManifest
closes #17837