-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(nextjs): Support native debugIds in turbopack #17853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
size-limit report 📦
|
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
* @returns true if Next.js version supports native debug ids for turbopack builds | ||
*/ | ||
export function supportsNativeDebugIds(version: string): boolean { | ||
// tbd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will still wait until we know in which stable version this lands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
if (version === '15.6.0-canary.36') { | ||
return true; | ||
} | ||
return false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super-l: we can simplify this.
if (version === '15.6.0-canary.36') { | |
return true; | |
} | |
return false; | |
return version === '15.6.0-canary.36' |
|
||
const newConfig: TurbopackOptions = { | ||
...userNextConfig.turbopack, | ||
...(shouldEnableNativeDebugIds ? { debugIds: true } : {}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q/l: is this something users could override (if for whatever reason they want to enable debugIds but not source maps upload in sentry)?
Adds support for vercel/next.js#84319
sentryDebugId
alongside the more genericdebugId
that Vercel uses.sentryDebugIds
anddebugIds
into the cache but since we generate them in this order,debugIds
will have precedence when there is a bundle with both keys in it.closes #17841