fix(react): Add POP
guard for long-running pageload
spans
#17867
+65
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the issue that occurs when an extra
navigation
transaction is created after a prematurely endedpageload
transaction in React Router lazy routes.This apparently occurs when there's a long-running pageload with lazy-routes (after fetching assets, there are multiple potentially long-running API calls happening).
This causes the
pageload
transaction to prematurely end, even before the fully parameterized transaction name is resolved. The reason is that there can be aPOP
event emitted, which we subscribe to create anavigation
transaction. This ends the ongoingpageload
transaction before its name is updated with a resolved parameterized route path, and starts anavigation
transaction, which contains the remaining spans that were supposed to be a part of thepageload
transaction.This fix makes sure the initial
POP
events are not necessarily treated asnavigation
pointers, which should fix both:navigation
transactions having a part ofpageload
spans.pageload
transaction names