fix(react): Add POP guard for long-running pageload spans
#17867
+211
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurtemizkan
force-pushed
the
onur/react-router-long-running-pageload-guard
branch
from
c5b63b9 to
b3027fd
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
chargome
approved these changes
Oct 8, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
| return; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Bug: Race Condition in Pageload Completion Logic
The pageload completion logic has a race condition. It can prematurely mark pageload as complete if the root span is missing, not necessarily because pageload finished. This causes legitimate POP navigation events immediately following pageload to be incorrectly ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the issue that occurs when an extra
navigationtransaction is created after a prematurely endedpageloadtransaction in React Router lazy routes.This apparently occurs when there's a long-running pageload with lazy-routes (after fetching assets, there are multiple potentially long-running API calls happening).
This causes the
pageloadtransaction to prematurely end, even before the fully parameterized transaction name is resolved. The reason is that there can be aPOPevent emitted, which we subscribe to create anavigationtransaction. This ends the ongoingpageloadtransaction before its name is updated with a resolved parameterized route path, and starts anavigationtransaction, which contains the remaining spans that were supposed to be a part of thepageloadtransaction.This fix makes sure the initial
POPevents are not necessarily treated asnavigationpointers, which should fix both:navigationtransactions having a part ofpageloadspans.pageloadtransaction names