-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(nextjs): Prepare for next 16 bundler default #17868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chargome
wants to merge
12
commits into
develop
Choose a base branch
from
cg-next-16-e2e
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d209fac
add new bundler detection
chargome 3e8681e
update detection
chargome 2b52582
some more tests
chargome 5fa6b29
update app dir test
chargome 1bc8187
update pages dir canary tests
chargome 2aa3877
add start commands for dev mode
chargome 1d46b0e
use canary 40
chargome b1e0687
Merge branch 'develop' into cg-next-16-e2e
chargome a0df026
skip webpack dev tests
chargome d05629f
test conditions for development-webpack
chargome 9ee2db2
only test prod for webpack
chargome 8abbfa5
Merge branch 'develop' into cg-next-16-e2e
chargome File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,12 +4,14 @@ | |
"private": true, | ||
"scripts": { | ||
"build": "next build > .tmp_build_stdout 2> .tmp_build_stderr || (cat .tmp_build_stdout && cat .tmp_build_stderr && exit 1)", | ||
"build:webpack": "next build --webpack > .tmp_build_stdout 2> .tmp_build_stderr || (cat .tmp_build_stdout && cat .tmp_build_stderr && exit 1)", | ||
"clean": "npx rimraf node_modules pnpm-lock.yaml", | ||
"test:prod": "TEST_ENV=production playwright test", | ||
"test:dev": "TEST_ENV=development playwright test", | ||
"test:dev-webpack": "TEST_ENV=development-webpack playwright test", | ||
"test:build": "pnpm install && pnpm build", | ||
"test:test-build": "pnpm ts-node --script-mode assert-build.ts", | ||
"test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build", | ||
"test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@latest && pnpm add react-dom@latest && pnpm build:webpack", | ||
"test:build-latest": "pnpm install && pnpm add next@latest && pnpm build", | ||
"test:build-13": "pnpm install && pnpm add [email protected] && pnpm build", | ||
"test:assert": "pnpm test:test-build && pnpm test:prod && pnpm test:dev" | ||
|
@@ -43,7 +45,8 @@ | |
"optionalVariants": [ | ||
{ | ||
"build-command": "pnpm test:build-canary", | ||
"label": "nextjs-app-dir (canary)" | ||
"label": "nextjs-app-dir (canary, webpack opt-in)", | ||
"assert-command": "pnpm test:prod" | ||
}, | ||
{ | ||
"build-command": "pnpm test:build-latest", | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,12 +4,14 @@ | |
"private": true, | ||
"scripts": { | ||
"build": "next build > .tmp_build_stdout 2> .tmp_build_stderr || (cat .tmp_build_stdout && cat .tmp_build_stderr && exit 1)", | ||
"build:webpack": "next build --webpack > .tmp_build_stdout 2> .tmp_build_stderr || (cat .tmp_build_stdout && cat .tmp_build_stderr && exit 1)", | ||
"clean": "npx rimraf node_modules pnpm-lock.yaml", | ||
"test:prod": "TEST_ENV=production playwright test", | ||
"test:dev": "TEST_ENV=development playwright test", | ||
"test:dev-webpack": "TEST_ENV=development-webpack playwright test", | ||
"test:build": "pnpm install && pnpm build", | ||
"test:test-build": "pnpm ts-node --script-mode assert-build.ts", | ||
"test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build", | ||
"test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@latest && pnpm add react-dom@latest && pnpm build:webpack", | ||
"test:build-latest": "pnpm install && pnpm add next@latest && pnpm add react@latest && pnpm add react-dom@latest && pnpm build", | ||
"test:build-13": "pnpm install && pnpm add [email protected] && pnpm build", | ||
"test:assert": "pnpm test:test-build && pnpm test:prod && pnpm test:dev" | ||
|
@@ -43,7 +45,8 @@ | |
"optionalVariants": [ | ||
{ | ||
"build-command": "pnpm test:build-canary", | ||
"label": "nextjs-pages-dir (canary)" | ||
"label": "nextjs-pages-dir (canary, webpack opt-in)", | ||
"assert-command": "pnpm test:prod" | ||
}, | ||
{ | ||
"build-command": "pnpm test:build-latest", | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
dev-packages/e2e-tests/test-applications/nextjs-pages-dir/tests/transactions.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Turbopack Version Threshold Mismatch
The
isTurbopackDefaultForVersion
function has inconsistencies in determining Turbopack as default for Next.js 15.x canary versions. The code's15.6.0-canary.40+
threshold conflicts with a comment stating15.6.0-canary.38
, leading to incorrect identification for15.6.0-canary.38
and15.6.0-canary.39
. Additionally, a comment inaccurately restricts the default to15.6.0-canary.40+
, while the logic correctly includes all15.7.x-canary
versions.Additional Locations (1)
packages/nextjs/src/config/util.ts#L69-L72