Skip to content

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Oct 7, 2025

Merge master branch into develop

@HazAT HazAT requested review from a team as code owners October 7, 2025 11:22
@github-actions github-actions bot enabled auto-merge October 7, 2025 11:22
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved automated PR


## 10.18.0

### Important Changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential bug: The new pinoIntegration uses tracingChannel without a Node.js version check, causing a crash on unsupported Node.js versions when the integration is enabled.
  • Description: The new pinoIntegration imports and uses tracingChannel from node:diagnostics_channel without a runtime check for Node.js version compatibility. The tracingChannel API is only available in Node.js versions >=18.19.0. When this integration is enabled in an application running on an older, incompatible Node.js version (e.g., 18.18.0), the application will crash during SDK initialization due to the failed import. This behavior is not caught by tests, as they are conditionally configured to run only on Node.js 20 and above.

  • Suggested fix: Add a runtime Node.js version check at the beginning of the pinoIntegration. If the running Node.js version is older than a compatible version (e.g., <18.19.0), the integration should be disabled and a warning should be logged, preventing the application crash.
    severity: 0.85, confidence: 0.95

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Contributor

github-actions bot commented Oct 7, 2025

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 9,316 - 8,994 +4%
GET With Sentry 1,402 15% 1,430 -2%
GET With Sentry (error only) 6,156 66% 6,248 -1%
POST Baseline 1,202 - 1,205 -0%
POST With Sentry 523 44% 555 -6%
POST With Sentry (error only) 1,068 89% 1,068 -
MYSQL Baseline 3,314 - 3,329 -0%
MYSQL With Sentry 450 14% 505 -11%
MYSQL With Sentry (error only) 2,691 81% 2,716 -1%

View base workflow run

@github-actions github-actions bot merged commit 420d3c6 into develop Oct 7, 2025
450 of 459 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants