feat(tracemetrics): Add trace metrics behind an experiments flag #17883
Conversation
This allows the js sdk to send in new trace metric protocol items, although this code is experimental since the schema may still change. Most of this has been copied from logs so some parts may need to be modified / removed later (eg. buffer) but this should allow us to start on UI work by sending in larger amounts of data from sentry js app to test grouping / aggregations etc.
…dd-experimental-metrics
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
size-limit report 📦
|
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
| * @param value - The value of the metric attribute. | ||
| * @returns The serialized metric attribute. | ||
| */ | ||
| export function metricAttributeToSerializedMetricAttribute(value: unknown): SerializedMetricAttributeValue { |
There was a problem hiding this comment.
nit: We can move this into a shared util with logs
|
|
||
| captureSerializedMetric(client, serializedMetric); | ||
|
|
||
| client.emit('afterCaptureMetric', metric); |
There was a problem hiding this comment.
q: Why no beforeCaptureMetric hook?
|
@k-fish looks good! I'll hijack your PR so we can land this today |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| type: 'trace_metric', | ||
| item_count: items.length, | ||
| content_type: 'application/vnd.sentry.items.trace-metric+json', | ||
| } as MetricContainerItem[0], |
There was a problem hiding this comment.
Bug: Metric Type Mismatch Causes Processing Issues
The createMetricEnvelope test expects the envelope item header type to be 'metric', but the createMetricContainerEnvelopeItem function correctly sets it to 'trace_metric'. This test expectation mismatch points to a potential ambiguity in the system regarding the canonical envelope item type for metrics, which could affect processing if 'trace_metric' is internally mapped to 'metric' in data category handling.
Additional Locations (2)
Summary
This allows the js sdk to send in new trace metric protocol items, although this code is experimental since the schema may still change. Most of this has been copied from logs so some parts may need to be modified / removed later (eg. api, buffer) but this should allow us to start on UI work by sending in larger amounts of data from sentry js app to test grouping / aggregations etc.