Skip to content

feat(build): preserveModules: false #18066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat(build): preserveModules: false #18066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/browser-utils/rollup.npm.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export default makeNPMConfigVariants(
// set preserveModules to true because we don't want to bundle everything into one file.
preserveModules:
process.env.SENTRY_BUILD_PRESERVE_MODULES === undefined
? true
? false
: Boolean(process.env.SENTRY_BUILD_PRESERVE_MODULES),
},
},
Expand Down
2 changes: 1 addition & 1 deletion packages/browser/rollup.npm.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export default makeNPMConfigVariants(
// set preserveModules to true because we don't want to bundle everything into one file.
preserveModules:
process.env.SENTRY_BUILD_PRESERVE_MODULES === undefined
? true
? false
: Boolean(process.env.SENTRY_BUILD_PRESERVE_MODULES),
},
},
Expand Down
8 changes: 7 additions & 1 deletion packages/bun/rollup.npm.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
import { makeBaseNPMConfig, makeNPMConfigVariants } from '@sentry-internal/rollup-utils';

export default makeNPMConfigVariants(makeBaseNPMConfig());
export default makeNPMConfigVariants(makeBaseNPMConfig({
packageSpecificConfig: {
output: {
preserveModules: false
}
}
}));
2 changes: 1 addition & 1 deletion packages/core/rollup.npm.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export default makeNPMConfigVariants(
// set preserveModules to true because we don't want to bundle everything into one file.
preserveModules:
process.env.SENTRY_BUILD_PRESERVE_MODULES === undefined
? true
? false
: Boolean(process.env.SENTRY_BUILD_PRESERVE_MODULES),
},
plugins: [
Expand Down
8 changes: 7 additions & 1 deletion packages/deno/rollup.npm.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
import { makeBaseNPMConfig, makeNPMConfigVariants } from '@sentry-internal/rollup-utils';

export default makeNPMConfigVariants(makeBaseNPMConfig(), { emitCjs: false });
export default makeNPMConfigVariants(makeBaseNPMConfig({
packageSpecificConfig: {
output: {
preserveModules: false
}
}
}), { emitCjs: false });
3 changes: 3 additions & 0 deletions packages/nestjs/rollup.npm.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,8 @@ import { makeBaseNPMConfig, makeNPMConfigVariants } from '@sentry-internal/rollu
export default makeNPMConfigVariants(
makeBaseNPMConfig({
entrypoints: ['src/index.ts', 'src/setup.ts'],
output: {
preserveModules: false
}
}),
);
2 changes: 1 addition & 1 deletion packages/node-core/rollup.npm.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export default [
output: {
// set exports to 'named' or 'auto' so that rollup doesn't warn
exports: 'named',
preserveModules: true,
preserveModules: false,
},
plugins: [
replace({
Expand Down
2 changes: 1 addition & 1 deletion packages/node-native/rollup.npm.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export default makeNPMConfigVariants(
dir: 'build',
// set exports to 'named' or 'auto' so that rollup doesn't warn
exports: 'named',
preserveModules: true,
preserveModules: false,
},
},
}),
Expand Down
2 changes: 1 addition & 1 deletion packages/node/rollup.npm.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export default [
output: {
// set exports to 'named' or 'auto' so that rollup doesn't warn
exports: 'named',
preserveModules: true,
preserveModules: false,
},
},
}),
Expand Down
3 changes: 3 additions & 0 deletions packages/react/rollup.npm.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ import { makeBaseNPMConfig, makeNPMConfigVariants } from '@sentry-internal/rollu
export default makeNPMConfigVariants(
makeBaseNPMConfig({
packageSpecificConfig: {
output: {
preserveModules: true,
},
external: ['react', 'react/jsx-runtime'],
},
sucrase: {
Expand Down
Loading