Skip to content

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Nov 12, 2025

WIP, Based on #18165

  • Unify attribute -> typed attribute conversion
  • Logs can now have array attributes
  • Apply scope attributes to logs

TBD:

  • permitting units requires extending the Log.attributes type to a similar object that users can pass into scope.setAttribute(s) to define units. I'd rather do this in a follow-up PR.

closes #18159

@Lms24 Lms24 changed the base branch from develop to lms/feat-core-scope-setAttributes November 12, 2025 11:46
@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.79 kB +0.07% +17 B 🔺
@sentry/browser - with treeshaking flags 23.29 kB +0.1% +22 B 🔺
@sentry/browser (incl. Tracing) 41.52 kB +0.05% +19 B 🔺
@sentry/browser (incl. Tracing, Profiling) 45.85 kB +0.05% +20 B 🔺
@sentry/browser (incl. Tracing, Replay) 79.94 kB +0.03% +22 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 69.67 kB +0.03% +18 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 84.62 kB +0.03% +20 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 96.87 kB +0.02% +18 B 🔺
@sentry/browser (incl. Feedback) 41.48 kB +0.06% +21 B 🔺
@sentry/browser (incl. sendFeedback) 29.48 kB +0.07% +18 B 🔺
@sentry/browser (incl. FeedbackAsync) 34.42 kB +0.07% +21 B 🔺
@sentry/react 26.51 kB +0.07% +18 B 🔺
@sentry/react (incl. Tracing) 43.52 kB +0.05% +18 B 🔺
@sentry/vue 29.24 kB +0.07% +18 B 🔺
@sentry/vue (incl. Tracing) 43.33 kB +0.05% +21 B 🔺
@sentry/svelte 24.81 kB +0.07% +17 B 🔺
CDN Bundle 27.11 kB +0.07% +18 B 🔺
CDN Bundle (incl. Tracing) 42.09 kB +0.05% +19 B 🔺
CDN Bundle (incl. Tracing, Replay) 78.61 kB +0.03% +19 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 84.1 kB +0.03% +23 B 🔺
CDN Bundle - uncompressed 79.49 kB +0.05% +34 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 124.87 kB +0.03% +34 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 240.9 kB +0.02% +34 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 253.66 kB +0.02% +34 B 🔺
@sentry/nextjs (client) 45.95 kB +0.04% +17 B 🔺
@sentry/sveltekit (client) 41.88 kB +0.05% +18 B 🔺
@sentry/node-core 51.11 kB +0.03% +12 B 🔺
@sentry/node 159.44 kB +0.02% +22 B 🔺
@sentry/node - without tracing 93 kB +0.03% +20 B 🔺
@sentry/aws-serverless 106.73 kB +0.02% +16 B 🔺

View base workflow run

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,842 - 8,680 +2%
GET With Sentry 1,818 21% 1,595 +14%
GET With Sentry (error only) 6,200 70% 5,988 +4%
POST Baseline 1,213 - 1,128 +8%
POST With Sentry 613 51% 529 +16%
POST With Sentry (error only) 1,070 88% 1,000 +7%
MYSQL Baseline 3,383 - 3,249 +4%
MYSQL With Sentry 521 15% 360 +45%
MYSQL With Sentry (error only) 2,754 81% 2,683 +3%

View base workflow run

@Lms24 Lms24 force-pushed the lms/feat-core-logs-apply-scope-attributes branch 2 times, most recently from 52339f2 to b97b3f4 Compare November 18, 2025 12:15
@Lms24 Lms24 force-pushed the lms/feat-core-scope-setAttributes branch 2 times, most recently from a3e204d to 205752c Compare November 18, 2025 16:51
@Lms24 Lms24 force-pushed the lms/feat-core-logs-apply-scope-attributes branch from 5053159 to e5785ea Compare November 18, 2025 16:52
@Lms24 Lms24 force-pushed the lms/feat-core-scope-setAttributes branch 2 times, most recently from fbbd768 to 04d75b1 Compare November 21, 2025 14:23
Base automatically changed from lms/feat-core-scope-setAttributes to develop November 21, 2025 14:42
@Lms24 Lms24 force-pushed the lms/feat-core-logs-apply-scope-attributes branch from e5785ea to 561085c Compare November 21, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply Scope attributes to logs

2 participants