fix(node-core): Ignore worker threads in OnUncaughtException #18689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
Lms24
approved these changes
Jan 5, 2026
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
I have to admit, I was a bit confused about this change first, because I didn't know that childProcessIntegration also covers worker threads. To me, processes and threads are something different 😅 ... should we rename or split up the integration?
Anyway, the change itself looks reasonable to me. Thanks for fixing!
Collaborator
|
Looks like it originally only supported child processes and then I added support for worker threads here #15105. It would probably make sense to rename it! |
timfish
approved these changes
Jan 5, 2026
Member
Author
I created a ticket for it for further discussions: #18698 |
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #18592
closes JS-1347
The onUncaughtException integration triggered for errors inside workers, which caused a wrong error code overall. Since we already have a Child Process integration which handles errors it would make most sense to disable the onUncaughtException integration entirely for workers.
Another option would also be to only ignore
shouldApplyFatalHandlingLogicfor workers, which was the main reason to exit the entire process, even though the error was handled - but I don't like this approach, since the child processes errors will be handled anyways in the other integration.Interesting finding: When using
--importor--requireCLI flags, these are propagated to worker threads, soSentry.init()runs twice: once in the main thread (isMainThread === true) and once in the worker (isMainThread === false). However, when using inlinerequire()inside a file, it is NOT propagated to workers, so it initializes only once withisMainThread === true. This means the bug primarily manifests with ESM (--import) or when CJS uses--require(which may be less common).The
caught-worker-inline.jstest always passes (inline require), whilecaught-worker.jswith--requireonly passes after the fix is applied, demonstrating this behavior.