ref: simplify usage of E_ALL #1067
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stayallive
approved these changes
Nov 17, 2025
Collaborator
stayallive
left a comment
stayallive
left a comment
There was a problem hiding this comment.
I don't really see how the linked PRs are relevant since I don't think any of these issue re-surfaced. But I agree that it's no longer needed. Sentry came from a place where PHP 5.4 and older were supported so this was an artifact of that. Good to clean that up.
Author
|
Apologies, didn't meant to sound like any issues had resurfaced. I guess the linked issue and PR and more "related" than "relevant"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove indirect usage of
E_STRICT. There is no need to use it, asE_ALLalready containsE_STRICT(since PHP 5.4.0).Issues
relates to: #962 (also see #963)