feat: Add support for capturing events with local scopes #1248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpnurmi
force-pushed
the
feat/local-scopes
branch
4 times, most recently
from
96a51c0 to
65217f0
Compare
jpnurmi
changed the title
|
Collaborator
Author
|
@supervacuus This is ready for a first pass. Things are looking promising for sentry-unreal: |
supervacuus
requested changes
Jun 3, 2025
Collaborator
supervacuus
left a comment
supervacuus
left a comment
There was a problem hiding this comment.
This looks largely good. I am primarily concerned about the ownership transfer to capture.
| #include "sentry_testsupport.h" | ||
| #include "sentry_utils.h" | ||
|
|
||
| SENTRY_TEST(scope_contexts) |
Collaborator
There was a problem hiding this comment.
Thanks for all of these ❤️
jpnurmi
force-pushed
the
feat/local-scopes
branch
from
2169001 to
b0967b8
Compare
> Transactions/spans do not make sense in this setup since they aren't > cloned and cannot be retrieved to create children.
jpnurmi
force-pushed
the
feat/local-scopes
branch
from
0e37061 to
1f9a57d
Compare
Collaborator
|
So, the only things open are:
|
don't assume any specific order for breadcrumbs with missing breadcrumbs
supervacuus
approved these changes
Jun 4, 2025
Collaborator
Author
|
Thanks! 🎉 |
7 tasks
1 task
Closed
6 tasks
coolguyzone
pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Oct 20, 2025
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. --> ## DESCRIBE YOUR PR Adds missing documentation for local scopes introduced earlier in sentry-native [0.9.0](https://github.com/getsentry/sentry-native/releases/tag/0.9.0): - getsentry/sentry-native#1248 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [x] Checked Vercel preview for correctness, including links - [x] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE <!-- Sentry employees and contractors can delete or ignore this section. --> Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for empty write-only local scopes as proposed in:
See also Hub & Scope Refactoring.
Closes #1226