Skip to content

feat: Implement the GPU Info gathering within the Native SDK #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 52 commits into
base: master
Choose a base branch
from
Open

feat: Implement the GPU Info gathering within the Native SDK #1336

wants to merge 52 commits into from

Conversation

@mujacica
Copy link
Contributor

@mujacica mujacica commented Aug 11, 2025 •
edited
Loading

  • Implement GPU Info Context for Native SDK
  • Support for Mac/Windows/Unix (Vulkan, Dynamically loaded)
  • Support for several Vendors
  • Added SENTRY_WITH_GPU_INFO option, ON by default on supported platforms
  • Include vulkan-headers as submodule

@github-actions
Copy link

github-actions bot commented Aug 11, 2025 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against f7eef2b

bruno-garcia
bruno-garcia reviewed Aug 11, 2025
View reviewed changes
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just skimmed things but seems great so far!

@mujacica mujacica marked this pull request as ready for review October 2, 2025 13:22
cursor[bot]

This comment was marked as outdated.

Sign in to view

mujacica added 23 commits October 2, 2025 17:39
@mujacica
feat: Implement the GPU Info gathering within the Native SDK
c65001f
@mujacica
Fix file format
fab50a7
@mujacica
Add changelog entry
e1854e3
@mujacica
Extend README with new SENTRY_WITH_GPU_INFO option
dc72b0e
@mujacica
Skip apple silicon tests on non darwin platforms
093d100
@mujacica
Enable GPU Info per default to test cmake on github runners
c3fc125
@mujacica
Resolve compiler issues on Linux
de8516a
@mujacica
Fix Windows builds
1bf85b3
@mujacica
Fix failing tests
cfb142b
@mujacica
Fix IOS builds
63285cd
@mujacica
Fix remaining failing tests
0be6800
@mujacica
Fix format
6d5d211
@mujacica
Keep GPU Info disabled by default
75436f6
@mujacica
Fix CMake for all platforms
b337dc9
@mujacica
Fix comments, and findings from testing
324aa86
@mujacica
Further testing fixes
15cbc84
@mujacica
Fix failing test
90e801e
@mujacica
Use Sentry wstr function instead of custom implementation
a56f85d
@mujacica
Simplify Unix implementation and CMakeLists
4c9023f
@mujacica
Add nvml support, add multi-gpu support
a5bc079
@mujacica
Fix linux complier warnings
18edccc
@mujacica
Fix file formats
86ba123
@mujacica
Fix build issues after refactoring
abd63a8
@bruno-garcia
Copy link
Member

bruno-garcia commented Oct 2, 2025

@sentry review

seer-by-sentry[bot]
seer-by-sentry bot reviewed Oct 2, 2025
View reviewed changes
supervacuus
supervacuus reviewed Oct 7, 2025
View reviewed changes
supervacuus
supervacuus requested changes Oct 7, 2025
View reviewed changes
Copy link
Collaborator

@supervacuus supervacuus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow my review message got lost... this looks great. Only minor topics that can be "fixed" or clarified.

mujacica and others added 4 commits October 9, 2025 10:40
@mujacica @supervacuus
Update src/gpu/sentry_gpu_vulkan.c
924aef3 
Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
@mujacica @supervacuus
Update src/gpu/sentry_gpu_vulkan.c
641744d 
Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
@mujacica @supervacuus
Update tests/unit/test_gpu.c
921f817 
Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
@mujacica @supervacuus
Update README.md
150e542 
Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

@mujacica @supervacuus
Update tests/unit/test_gpu.c
6b37c65 
Co-authored-by: Mischan Toosarani-Hausberger <[email protected]>
cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

@mujacica mujacica requested a review from supervacuus October 9, 2025 11:06
JoshuaMoelans
JoshuaMoelans reviewed Oct 9, 2025
View reviewed changes
cursor[bot]

This comment was marked as outdated.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bruno-garcia bruno-garcia bruno-garcia left review comments

@JoshuaMoelans JoshuaMoelans JoshuaMoelans left review comments

@seer-by-sentry seer-by-sentry[bot] seer-by-sentry[bot] left review comments

@cursor cursor[bot] cursor[bot] left review comments

@supervacuus supervacuus supervacuus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mujacica @bruno-garcia @supervacuus @JoshuaMoelans