feat: add runtime API to query user consent requirement #1443
+66
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tustanivsky
requested review from
JoshuaMoelans,
jpnurmi,
mujacica and
supervacuus
nwhite-riot
reviewed
Nov 4, 2025
mujacica
reviewed
Nov 5, 2025
| return rv; | ||
| } | ||
|
|
||
| int |
Contributor
There was a problem hiding this comment.
int needed or we could use bool here? require_user_consent is a boolean.
Collaborator
Author
There was a problem hiding this comment.
The existing public API uses int for similar boolean-style returns so the idea was just to keep it consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new public API function
sentry_user_consent_is_required()that allows applications to query at runtime whether user consent is required. This complements the existing consent management APIs and addresses a gap where the consent requirement could only be queried during initialization with direct access to the options object.Closes #1441