-
-
Notifications
You must be signed in to change notification settings - Fork 201
Add Metrics API #985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Metrics API #985
Conversation
This reverts commit 3399f78.
|
@tustanivsky, do you already understand why the Windows tests time out? |
Not really, things work as expected on Windows when running tests locally. |
I think it happens because a debug assertion failed, and we are stuck in a dialog on the CI runner. Will investigate. Since it is also stuck in |
The sentry metrics normalization explicitly mentions not using `\w` in their regex-spec because they exclude diacritics. It seems Windows asserts in isalnum() on chars outside [-1, 127] and we should ensure that before we pass the char on.
|
As we're fundamentally shifting how Metrics will work at Sentry, I suggest putting this PR on hold for now. At least until we know how the next steps look like. |
Thanks for the heads up, @cleptric. |
|
@tustanivsky, I would approve this PR in its current state. At least I don't see any blockers for a merge. But given the news in #985 (comment), I will keep merging blocked. When this gets unblocked, I would appreciate it if @markushi could also give this a quick review so we have the perspective of another metrics implementer. CC: @kahest |
|
Closing this PR since Metrics have been deprecated. |
This PR introduces the Metrics API for
sentry-native.Current progress:
Related to #953