Skip to content

ref(logs): extract attribute compilation to dedicated method in LogsHandler #1931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ref(logs): extract attribute compilation to dedicated method in LogsHandler #1931

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9dcb383
ref(logs): extract attribute compilation to dedicated method in LogsH…
huangdijia Sep 30, 2025
921493a
ref(logs): use Arr utility to simplify attribute compilation in compi…
huangdijia Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/Monolog/LogsHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
use Monolog\LogRecord;
use Sentry\Logs\LogLevel;
use Sentry\Logs\Logs;
use Sentry\Util\Arr;

class LogsHandler implements HandlerInterface
{
Expand Down Expand Up @@ -66,7 +67,7 @@
self::getSentryLogLevelFromMonologLevel($record['level']),
$record['message'],
[],
array_merge($record['context'], $record['extra'], ['sentry.origin' => 'auto.logger.monolog'])
$this->compileAttributes($record)
);

return $this->bubble === false;
Expand Down Expand Up @@ -123,4 +124,17 @@
// Just in case so that the destructor can never fail.
}
}

/**
* @param array<string, mixed>|LogRecord $record
*/
protected function compileAttributes($record): array

Check failure on line 131 in src/Monolog/LogsHandler.php

View workflow job for this annotation

GitHub Actions / PHPStan 

Method Sentry\Monolog\LogsHandler::compileAttributes() return type has no value type specified in iterable type array.
{
return [
...Arr::simpleDot(['context' => $record['context']]),
...Arr::simpleDot(['extra' => $record['extra']]),
'log.channel' => $record['channel'],
'sentry.origin' => 'auto.logger.monolog',
];
}
}
Loading