Skip to content

Remove flaky test #3626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Remove flaky test #3626

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86c27c7
Remove flaky test
sentrivana Oct 8, 2024
df174ff
Merge branch 'master' into ivana/remove-flaky-test
sentrivana Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions tests/test_basics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
setup_integrations,
)
from sentry_sdk.integrations.logging import LoggingIntegration
from sentry_sdk.integrations.redis import RedisIntegration
from sentry_sdk.integrations.stdlib import StdlibIntegration
from sentry_sdk.scope import add_global_event_processor
from sentry_sdk.utils import get_sdk_name, reraise
Expand Down Expand Up @@ -887,13 +886,6 @@ def test_functions_to_trace_with_class(sentry_init, capture_events):
assert event["spans"][1]["description"] == "tests.test_basics.WorldGreeter.greet"


def test_redis_disabled_when_not_installed(sentry_init):
with ModuleImportErrorSimulator(["redis"], ImportError):
sentry_init()

assert sentry_sdk.get_client().get_integration(RedisIntegration) is None


def test_multiple_setup_integrations_calls():
first_call_return = setup_integrations([NoOpIntegration()], with_defaults=False)
assert first_call_return == {NoOpIntegration.identifier: NoOpIntegration()}
Expand Down
Loading