Skip to content

Conversation

@sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Oct 15, 2024

mypy updated itself and started throwing:

linters: commands[2]> mypy sentry_sdk
sentry_sdk/integrations/__init__.py:145: error: List comprehension has incompatible type List[sentry_sdk.integrations.<subclass of "Integration" and "type">1 | type[Integration]]; expected List[sentry_sdk.integrations.<subclass of "Integration" and "type"> | type[Integration]]  [misc]

Locally it's also complaining that it cannot find types for httpcore, so adding that to linter reqs.

@sentrivana sentrivana enabled auto-merge (squash) October 15, 2024 08:26
@codecov
Copy link

codecov bot commented Oct 15, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
14814 1 14813 4379
View the top 1 failed tests by shortest run time
tests.test_transport test_transport_works[threads-False-br-9-True-close-True]
Stack Traces | 0.675s run time
tests/test_transport.py:175: in test_transport_works
    assert not err and not out
E   assert (not '--- Logging error ---\nTraceback (most recent call last):\n  File ".../hostedtoolcache/Python/3.6.15.../x64/lib/python3...lhandlers\n    return old_callhandlers(self, record)\nMessage: \'background worker got kill request\'\nArguments: ()\n')

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@sentrivana sentrivana disabled auto-merge October 15, 2024 10:41
@sentrivana sentrivana enabled auto-merge (squash) October 15, 2024 10:41
@sentrivana sentrivana merged commit 8a7e226 into master Oct 15, 2024
136 checks passed
@sentrivana sentrivana deleted the ivana/fix-mypy branch October 15, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants