feat(flags): Add LaunchDarkly Integration #3679
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## cmanallen/flags-open-feature-integration #3679 +/- ##
============================================================================
- Coverage 84.33% 83.38% -0.95%
============================================================================
Files 135 136 +1
Lines 14326 14537 +211
Branches 2413 2469 +56
============================================================================
+ Hits 12082 12122 +40
- Misses 1494 1666 +172
+ Partials 750 749 -1
|
cmanallen
left a comment
cmanallen
left a comment
There was a problem hiding this comment.
Looks good! I'll let you work through the test coverage before approving.
| if client is None: | ||
| try: | ||
| client = ldclient.get() # global singleton. | ||
| except Exception as exc: | ||
| raise DidNotEnable("Error getting LaunchDarkly client. " + repr(exc)) | ||
|
|
||
| if not client.is_initialized(): | ||
| raise DidNotEnable("LaunchDarkly client is not initialized.") | ||
|
|
||
| # Register the flag collection hook with the given client. | ||
| client.add_hook(LaunchDarklyHook()) |
There was a problem hiding this comment.
This needs to be moved to setup_once. You can call sentry_sdk.get_client().get_integration(LaunchDarklyIntegration) to get the explicitly passed client from the init.
There was a problem hiding this comment.
Got it, just updated. When is setup_once called? Do you know when setup_once is called? Why is it a staticmethod?
|
Do we need to worry about the failing checks, ex "Test Miscellaneous / Miscellaneous (latest) (3.12, ubuntu-20.04) (pull_request)" |
This reverts commit ead840f.
cmanallen
merged commit 018cb0f
into
cmanallen/flags-open-feature-integration
Ref: