Skip to content

Conversation

@sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Oct 23, 2024

We can't use data stored on the span because it might be a NonRecordingSpan that doesn't carry any data.

Fixes #3681

@codecov
Copy link

codecov bot commented Oct 23, 2024

❌ 2969 Tests Failed:

Tests completed Failed Passed Skipped
20358 2969 17389 4461
View the top 3 failed tests by shortest run time
tests.integrations.litestar.test_litestar test_middleware_partial_receive_send
Stack Traces | 0s run time
No failure message available
tests.integrations.litestar.test_litestar test_middleware_spans
Stack Traces | 0s run time
No failure message available
tests.test_scope test_with_isolation_scope_data
Stack Traces | 0.001s run time
tests/test_scope.py:387: in test_with_isolation_scope_data
    assert scope._tags == {"before_isolation_scope": 1}
E   AssertionError: assert {} == {'before_isolation_scope': 1}
E     Right contains 1 more item:
E     {'before_isolation_scope': 1}
E     Full diff:
E     - {'before_isolation_scope': 1}
E     + {}

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@sentrivana sentrivana marked this pull request as ready for review October 23, 2024 11:18
Copy link
Contributor

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@sentrivana sentrivana merged commit f02c204 into potel-base Oct 23, 2024
16 of 122 checks passed
@sentrivana sentrivana deleted the ivana/potel/fix-asyncpg-breadcrumbs branch October 23, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants