Skip to content

Conversation

@szokeasaurusrex
Copy link
Member


Thank you for contributing to sentry-python! Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. The AWS Lambda tests additionally require a maintainer to add a special label, and they will fail until this label is added.

@codecov
Copy link

codecov bot commented Oct 28, 2024

❌ 95 Tests Failed:

Tests completed Failed Passed Skipped
13800 95 13705 4101
View the top 3 failed tests by shortest run time
tests.integrations.redis.test_redis test_basic
Stack Traces | 0.065s run time
.../integrations/redis/test_redis.py:29: in test_basic
    (crumb,) = event["breadcrumbs"]["values"]
E   ValueError: too many values to unpack (expected 1)
tests.integrations.redis.test_redis test_breadcrumbs
Stack Traces | 0.073s run time
.../integrations/redis/test_redis.py:236: in test_breadcrumbs
    assert crumbs[1] == {
E   assert {'message': "SET 'somekey1' 'aaaaaaaaaaa...", 'type': 'redis', 'category': 'redis', 'data': {'redis.is_cluster': False, 'redis.command': 'SET', 'db.operation': 'SET', 'redis.key': 'somekey1'}, 'timestamp': '2024-10-29T13:04:10.115529Z'} == {'message': "SET 'somekey2' 'bbbbbbbbbb'", 'type': 'redis', 'category': 'redis', 'data': {'db.operation': 'SET', 'redis.is_cluster': False, 'redis.command': 'SET', 'redis.key': 'somekey2'}, 'timestamp': '2024-10-29T13:04:10.115529Z'}
E     
E     Common items:
E     {'category': 'redis',
E      'timestamp': '2024-10-29T13:04:10.115529Z',
E      'type': 'redis'}
E     Differing items:
E     {'data': {'db.operation': 'SET', 'redis.command': 'SET', 'redis.is_cluster': False, 'redis.key': 'somekey1'}} != {'data': {'db.operation': 'SET', 'redis.command': 'SET', 'redis.is_cluster': False, 'redis.key': 'somekey2'}}
E     {'message': "SET 'somekey1' 'aaaaaaaaaaa..."} != {'message': "SET 'somekey2' 'bbbbbbbbbb'"}
E     
E     Full diff:
E       {
E           'category': 'redis',
E           'data': {
E               'db.operation': 'SET',
E               'redis.command': 'SET',
E               'redis.is_cluster': False,
E     -         'redis.key': 'somekey2',
E     ?                              ^
E     +         'redis.key': 'somekey1',
E     ?                              ^
E           },
E     -     'message': "SET 'somekey2' 'bbbbbbbbbb'",
E     +     'message': "SET 'somekey1' 'aaaaaaaaaaa...",
E           'timestamp': '2024-10-29T13:04:10.115529Z',
E           'type': 'redis',
E       }
tests.integrations.redis.test_redis_cache_module test_no_cache_basic
Stack Traces | 0.073s run time
.../integrations/redis/test_redis_cache_module.py:32: in test_no_cache_basic
    assert len(spans) == 1
E   assert 13 == 1
E    +  where 13 = len([{'data': {'db.name': '0', 'db.system': 'redis', 'server.address': '808a129d60cb402c80aa02e656646aed', 'server.port': 6379, ...}, 'description': "GET 'mycachekey'", 'op': 'db.redis', 'origin': 'auto.db.redis', ...}, {'data': {'db.name': '0', 'db.system': 'redis', 'server.address': '808a129d60cb402c80aa02e656646aed', 'server.port': 6379, ...}, 'description': "GET 'mycachekey'", 'op': 'db.redis', 'origin': 'auto.db.redis', ...}, {'data': {'db.name': '0', 'db.system': 'redis', 'server.address': '808a129d60cb402c80aa02e656646aed', 'server.port': 6379, ...}, 'description': "GET 'mycachekey'", 'op': 'db.redis', 'origin': 'auto.db.redis', ...}, {'data': {'db.name': '0', 'db.system': 'redis', 'server.address': '808a129d60cb402c80aa02e656646aed', 'server.port': 6379, ...}, 'description': "GET 'mycachekey'", 'op': 'db.redis', 'origin': 'auto.db.redis', ...}, {'data': {'db.name': '0', 'db.system': 'redis', 'server.address': '808a129d60cb402c80aa02e656646aed', 'server.port': 6379, ...}, 'description': "GET 'mycachekey'", 'op': 'db.redis', 'origin': 'auto.db.redis', ...}, {'data': {'db.name': '0', 'db.system': 'redis', 'server.address': '808a129d60cb402c80aa02e656646aed', 'server.port': 6379, ...}, 'description': "GET 'mycachekey'", 'op': 'db.redis', 'origin': 'auto.db.redis', ...}, ...])

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/unpin-pytest-redis branch from 8f7b475 to 11c0d3e Compare October 29, 2024 13:01
This was referenced Oct 29, 2024
@szokeasaurusrex szokeasaurusrex linked an issue Oct 29, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unpin Pytest on Redis tests

2 participants