Skip to content

Conversation

@nellaG
Copy link

@nellaG nellaG commented Nov 2, 2024

The propagate_traces option is not documented and was superseded by trace_propagation_targets. This has been deprecated for a while and will now be removed.

Refs #3106

nellaG and others added 2 commits November 2, 2024 15:17
`propagate_traces` is not documented and superseded by
`trace_propagation_targets`.

Refs getsentry#3106
@antonpirker
Copy link
Contributor

Hey @nellaG,

thanks for the contribution! As this has to go out in a Major (it will be part in SDK 3.0) this will stay around for some while until we are ready to prepare 3.0. So I guess this will happen somewhen in spring 2025.

@antonpirker antonpirker changed the title ref(celery): remove deprecated propagate_traces option [Breaking] Remove deprecated propagate_traces option. Jan 14, 2025
@codecov
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.12%. Comparing base (9ff100a) to head (367d2a6).
Report is 125 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3725      +/-   ##
==========================================
- Coverage   80.15%   80.12%   -0.03%     
==========================================
  Files         139      139              
  Lines       15391    15388       -3     
  Branches     2596     2595       -1     
==========================================
- Hits        12337    12330       -7     
- Misses       2208     2220      +12     
+ Partials      846      838       -8     
Files with missing lines Coverage Δ
sentry_sdk/consts.py 93.27% <ø> (ø)
sentry_sdk/integrations/celery/__init__.py 86.49% <100.00%> (-0.06%) ⬇️
sentry_sdk/scope.py 85.39% <ø> (+0.23%) ⬆️

... and 4 files with indirect coverage changes

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nellaG, thank you for the contribution!

There are two options named propagate_traces, one is a general SDK option (the one in sentry_sdk/consts.py) and one is a Celery integration specific option. We only want to remove the general one, but leave propagate_traces untouched in all Celery files.

@sentrivana
Copy link
Contributor

Continuing this in #4206.

@sentrivana sentrivana closed this Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking change needs to go out in a major SDK 3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants