Skip to content

Conversation

@antonpirker
Copy link
Contributor

After thinking about high volume servers, creating a thread on each request is probably a lot of overhead.

So this is now a version, to check the duration of the transaction when a span is closed.

@codecov
Copy link

codecov bot commented Nov 29, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
15499 1 15498 4436
View the top 1 failed tests by shortest run time
tests.integrations.wsgi.test_wsgi test_long_running_transaction_finished
Stack Traces | 1.67s run time
.../integrations/wsgi/test_wsgi.py:541: in test_long_running_transaction_finished
    assert (
E   AssertionError: Long running transaction has not been finished after a set maximum duration
E   assert 1.050503 <= (1 * 1.05)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@antonpirker antonpirker requested review from sentrivana and sl0thentr0py and removed request for sentrivana December 2, 2024 10:21
@sl0thentr0py
Copy link
Member

@antonpirker this needs to rebased after the revert

@antonpirker antonpirker marked this pull request as draft December 5, 2024 13:00
@antonpirker
Copy link
Contributor Author

As we are moving to Potel, we will not merge this, because the performance part of the SDK will be done by OpenTelementry instrumentations in the future. So this is not needed anymore.

@antonpirker antonpirker deleted the antonpirker/remove-thread-timer-in-wsgi branch April 22, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants