Skip to content

Conversation

@sentrivana
Copy link
Contributor

Similar to split_tox_gh_actions, run the tox generation script in CI and compare the resulting tox.ini to the committed one. If there are changes, this most likely means someone edited tox.ini directly instead of the template. Make the check fail in that case.

@sentrivana sentrivana marked this pull request as ready for review January 20, 2025 14:57
@codecov
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.20%. Comparing base (c2c6450) to head (b7219bc).
Report is 3 commits behind head on ivana/tox-script-1.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           ivana/tox-script-1    #3972      +/-   ##
======================================================
- Coverage               80.20%   80.20%   -0.01%     
======================================================
  Files                     139      139              
  Lines                   15394    15394              
  Branches                 2596     2596              
======================================================
- Hits                    12347    12346       -1     
+ Misses                   2202     2201       -1     
- Partials                  845      847       +2     

see 2 files with indirect coverage changes

@sentrivana sentrivana marked this pull request as draft January 20, 2025 15:12
@sentrivana
Copy link
Contributor Author

sentrivana commented Jan 20, 2025

I will close this one. It'd actually bug us not just when there were manual edits, but also if a new version of a tested framework came out. Have to figure out a better way for this.

@sentrivana sentrivana closed this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants