Revert "feat(tracing): Add propagate_traces deprecation warning (#3899)"
#4055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" This reverts commit 8a70b76.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #4055 +/- ##
==========================================
- Coverage 79.57% 79.53% -0.05%
==========================================
Files 140 140
Lines 15510 15508 -2
Branches 2628 2628
==========================================
- Hits 12342 12334 -8
- Misses 2335 2337 +2
- Partials 833 837 +4
|
szokeasaurusrex
requested changes
Feb 14, 2025
Member
There was a problem hiding this comment.
I don't think we should revert this change. We want to deprecate propagate_traces because we intend to remove it in the next major, and want to give our users notice to stop using it. Please see my comment on your issue
Edit: we should only revert adding the deprecation warning to the Celery propagate traces. The other deprecation should stay
sl0thentr0py
approved these changes
Feb 14, 2025
Member
Author
|
@szokeasaurusrex Requires your approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4054
We should log deprecation notices but since this notice is not actionable it should be removed.