Skip to content

Conversation

@Zylphrex
Copy link
Member

The start_profiler and stop_profiler functions were renamed to start_profile_session and stop_profile_session respectively.

The `start_profiler` and `stop_profiler` functions were renamed to
`start_profile_session` and `stop_profile_session` respectively.
@Zylphrex Zylphrex requested a review from sentrivana February 14, 2025 20:36
@codecov
Copy link

codecov bot commented Feb 14, 2025

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
22967 4 22963 5843
View the top 3 failed test(s) by shortest run time
tests.test_basics test_classmethod_tracing
Stack Traces | 0.126s run time
tests/test_basics.py:946: in test_classmethod_tracing
    assert fake_start_child.call_count == 1
E   AssertionError: assert 2 == 1
E    +  where 2 = <MagicMock name='mock.start_child' id='139689654422928'>.call_count
tests.integrations.stdlib.test_httplib test_span_origin
Stack Traces | 0.219s run time
.../integrations/stdlib/test_httplib.py:384: in test_span_origin
    conn.request("GET", "/foo")
.../hostedtoolcache/Python/3.8.18.........................../x64/lib/python3.8/http/client.py:1256: in request
    self._send_request(method, url, body, headers, encode_chunked)
.../hostedtoolcache/Python/3.8.18.........................../x64/lib/python3.8/http/client.py:1302: in _send_request
    self.endheaders(body, encode_chunked=encode_chunked)
.../hostedtoolcache/Python/3.8.18.........................../x64/lib/python3.8/http/client.py:1251: in endheaders
    self._send_output(message_body, encode_chunked=encode_chunked)
.../hostedtoolcache/Python/3.8.18.........................../x64/lib/python3.8/http/client.py:1011: in _send_output
    self.send(msg)
.../hostedtoolcache/Python/3.8.18.........................../x64/lib/python3.8/http/client.py:951: in send
    self.connect()
.../hostedtoolcache/Python/3.8.18.........................../x64/lib/python3.8/http/client.py:1425: in connect
    self.sock = self._context.wrap_socket(self.sock,
.../hostedtoolcache/Python/3.8.18.........................../x64/lib/python3.8/ssl.py:500: in wrap_socket
    return self.sslsocket_class._create(
.../hostedtoolcache/Python/3.8.18.........................../x64/lib/python3.8/ssl.py:1073: in _create
    self.do_handshake()
.../hostedtoolcache/Python/3.8.18.........................../x64/lib/python3.8/ssl.py:1342: in do_handshake
    self._sslobj.do_handshake()
E   ssl.SSLError: [SSL: TLSV1_ALERT_INTERNAL_ERROR] tlsv1 alert internal error (_ssl.c:1131)
tests.integrations.stdlib.test_httplib test_span_origin
Stack Traces | 0.229s run time
.../integrations/stdlib/test_httplib.py:384: in test_span_origin
    conn.request("GET", "/foo")
.../hostedtoolcache/Python/3.8.18.........................../x64/lib/python3.8/http/client.py:1256: in request
    self._send_request(method, url, body, headers, encode_chunked)
.../hostedtoolcache/Python/3.8.18.........................../x64/lib/python3.8/http/client.py:1302: in _send_request
    self.endheaders(body, encode_chunked=encode_chunked)
.../hostedtoolcache/Python/3.8.18.........................../x64/lib/python3.8/http/client.py:1251: in endheaders
    self._send_output(message_body, encode_chunked=encode_chunked)
.../hostedtoolcache/Python/3.8.18.........................../x64/lib/python3.8/http/client.py:1011: in _send_output
    self.send(msg)
.../hostedtoolcache/Python/3.8.18.........................../x64/lib/python3.8/http/client.py:951: in send
    self.connect()
.../hostedtoolcache/Python/3.8.18.........................../x64/lib/python3.8/http/client.py:1425: in connect
    self.sock = self._context.wrap_socket(self.sock,
.../hostedtoolcache/Python/3.8.18.........................../x64/lib/python3.8/ssl.py:500: in wrap_socket
    return self.sslsocket_class._create(
.../hostedtoolcache/Python/3.8.18.........................../x64/lib/python3.8/ssl.py:1073: in _create
    self.do_handshake()
.../hostedtoolcache/Python/3.8.18.........................../x64/lib/python3.8/ssl.py:1342: in do_handshake
    self._sslobj.do_handshake()
E   ssl.SSLError: [SSL: TLSV1_ALERT_INTERNAL_ERROR] tlsv1 alert internal error (_ssl.c:1131)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@Zylphrex Zylphrex merged commit a5ce968 into master Feb 18, 2025
142 checks passed
@Zylphrex Zylphrex deleted the txiao/feat/add-new-functions-to-start-and-stop-continuous-profiler branch February 18, 2025 16:05
viglia added a commit that referenced this pull request Mar 19, 2025
…on (#4162)

Revert back to using `start_profiler` and `stop_profiler` function names
and deprecate the `*_session` ones instead.

Prior PR that introduced the change we're undoing:
#4056
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants