Fixed bug when cron_jobs is set to None in arq integration
#4115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #4115 +/- ##
==========================================
- Coverage 79.60% 79.57% -0.04%
==========================================
Files 140 140
Lines 15581 15581
Branches 2643 2643
==========================================
- Hits 12404 12399 -5
- Misses 2338 2343 +5
Partials 839 839
|
antonpirker
changed the title
cron_jobs is set to None in arq integration
szokeasaurusrex
approved these changes
Mar 3, 2025
sentrivana
pushed a commit
that referenced
this pull request
Mar 10, 2025
Handle `None` values in arq configuration gracefully. Fixes #3827
ronnix
added a commit
to ronnix/sentry-python
that referenced
this pull request
May 8, 2025
Arq settings can be defined as a dictionary or a class. When using a class inheriting from `WorkerSettingsBase`, the default value for `cron_jobs` is `None`. This causes a `TypeError: 'NoneType' object is not iterable` exception in Sentry when starting the worker. This fix is a followup to getsentry#4115 which handled the issue for the other settings formats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle
Nonevalues in arq configuration gracefully.Fixes #3827
Unfortunately our test setup for arq does not allow for testing
Nonevalues in the configuration because they are changed to[]in the arq init code in the test suite here and here.This is why I have not added additional tests for this bug fix.