Skip to content

fix(bottle): Prevent internal error on 404 #4131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2025
Merged

fix(bottle): Prevent internal error on 404 #4131

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf31e17
fix(bottle): Prevent internal error on 404
sentrivana Mar 12, 2025
38c304b
Merge branch 'master' into ivana/bottle-no-internal-error
sentrivana Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions sentry_sdk/integrations/bottle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,14 +177,20 @@ def _set_transaction_name_and_source(event, transaction_style, request):
name = ""

if transaction_style == "url":
name = request.route.rule or ""
try:
name = request.route.rule or ""
except RuntimeError:
pass

elif transaction_style == "endpoint":
name = (
request.route.name
or transaction_from_function(request.route.callback)
or ""
)
try:
name = (
request.route.name
or transaction_from_function(request.route.callback)
or ""
)
except RuntimeError:
pass

event["transaction"] = name
event["transaction_info"] = {"source": SOURCE_FOR_STYLE[transaction_style]}
Expand Down
Loading