Skip to content

Conversation

@szokeasaurusrex
Copy link
Member

My proposal for reporting traces_sampler errors. Do you all think this makes sense?

Fixes #2582


Thank you for contributing to sentry-python! Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. The AWS Lambda tests additionally require a maintainer to add a special label, and they will fail until this label is added.

My proposal for reporting `traces_sampler` errors. Do you all think this makes sense?

Fixes #2582
@codecov
Copy link

codecov bot commented Mar 18, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
23750 1 23749 5848
View the top 1 failed test(s) by shortest run time
tests.profiler.test_continuous_profiler test_continuous_profiler_manual_start_and_stop_sampled[non-experiment-start_profile_session/stop_profile_session-thread]
Stack Traces | 0.2s run time
tests/profiler/test_continuous_profiler.py:344: in test_continuous_profiler_manual_start_and_stop_sampled
    assert_single_transaction_with_profile_chunks(envelopes, thread)
tests/profiler/test_continuous_profiler.py:140: in assert_single_transaction_with_profile_chunks
    assert len(items["profile_chunk"]) > 0
E   assert 0 > 0
E    +  where 0 = len([])

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@szokeasaurusrex
Copy link
Member Author

Per discussion with @sl0thentr0py and @cleptric, by design, we don't report errors in callbacks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sentry doesn't report errors in the traces_sampler function

2 participants