Skip to content

Fixed flaky test #4165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 20, 2025
Merged

Fixed flaky test #4165

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f5f7ffe
Updated test, so hopefully it is not flaky anymore
antonpirker Mar 19, 2025
910f683
linting
antonpirker Mar 19, 2025
a7e12c1
Merge branch 'master' into antonpirker/fix-test
antonpirker Mar 19, 2025
7fb4b42
Merge branch 'master' into antonpirker/fix-test
antonpirker Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 8 additions & 17 deletions tests/integrations/stdlib/test_httplib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,25 +398,16 @@ def test_http_timeout(monkeypatch, sentry_init, capture_envelopes):

envelopes = capture_envelopes()

with start_transaction(op="op", name="name"):
try:
conn = HTTPSConnection("www.squirrelchasers.com")
conn.request("GET", "/top-chasers")
with pytest.raises(TimeoutError):
with start_transaction(op="op", name="name"):
conn = HTTPSConnection("www.example.com")
conn.request("GET", "/bla")
conn.getresponse()
except Exception:
pass

items = [
item
for envelope in envelopes
for item in envelope.items
if item.type == "transaction"
]
assert len(items) == 1

transaction = items[0].payload.json

(transaction_envelope,) = envelopes
transaction = transaction_envelope.get_transaction_event()
assert len(transaction["spans"]) == 1

span = transaction["spans"][0]
assert span["op"] == "http.client"
assert span["description"] == "GET https://www.squirrelchasers.com/top-chasers"
assert span["description"] == "GET https://www.example.com/bla"
Loading