Skip to content

Conversation

@antonpirker
Copy link
Contributor

This is the first part of #4102

@antonpirker antonpirker requested a review from a team as a code owner April 1, 2025 10:45
@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.53%. Comparing base (d0d70a5) to head (ca70d2b).
Report is 8 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4222      +/-   ##
==========================================
+ Coverage   79.48%   79.53%   +0.05%     
==========================================
  Files         141      141              
  Lines       15809    15810       +1     
  Branches     2703     2703              
==========================================
+ Hits        12565    12574       +9     
+ Misses       2382     2375       -7     
+ Partials      862      861       -1     
Files with missing lines Coverage Δ
sentry_sdk/tracing.py 77.77% <100.00%> (+0.04%) ⬆️

... and 4 files with indirect coverage changes

@antonpirker antonpirker requested a review from sentrivana April 1, 2025 10:59
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as #4221; it looks like we use Span.set_data in many places – I think we should remove those usages first to avoid potentially causing users to encounter this deprecation warning

@antonpirker
Copy link
Contributor Author

Then the deprecation message will only happen in 3.0. So I am closing this.

@antonpirker antonpirker closed this Apr 3, 2025
@antonpirker antonpirker deleted the antonpirker/deprecate-set-data branch April 22, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants