-
Notifications
You must be signed in to change notification settings - Fork 567
ref: Move sampler out of integrations/opentelemetry/
#4258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## potel-base #4258 +/- ##
===========================================
Coverage 83.59% 83.60%
===========================================
Files 144 145 +1
Lines 14660 14662 +2
Branches 2324 2324
===========================================
+ Hits 12255 12258 +3
Misses 1687 1687
+ Partials 718 717 -1
|
integrations/opentelemetry/
|
@sentrivana actually I have a question about this PR (and the related ones depending on it): It looks like you are moving all of these files directly under I think keeping them in the same directory might make sense, since this Otel-span stuff is all still closely related to each other |
|
Changed the new location to |
Moving stuff out of
integrations/opentelemetry/step by step since there is no OpenTelemetry integration anymore -- it's part of the core SDK.This moves
sentry_sdk/integrations/opentelemetry/sampler.py->sentry_sdk/opentelemetry/sampler.pyReferences #3853