feat(sessions): Add top-level start- and end session methods #4474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #4474 +/- ##
==========================================
+ Coverage 80.67% 80.68% +0.01%
==========================================
Files 156 156
Lines 16461 16467 +6
Branches 2799 2799
==========================================
+ Hits 13280 13287 +7
Misses 2296 2296
+ Partials 885 884 -1
|
sentrivana
approved these changes
Jun 17, 2025
Contributor
sentrivana
left a comment
sentrivana
left a comment
There was a problem hiding this comment.
LGTM but please see comment first
tests/test_api_sessions.py
Outdated
| @@ -0,0 +1,50 @@ | |||
| import sentry_sdk | |||
Contributor
There was a problem hiding this comment.
Can we move these tests to the existing tests/test_sessions.py and delete this file?
szokeasaurusrex
pushed a commit
that referenced
this pull request
Jun 24, 2025
szokeasaurusrex
force-pushed
the
cursor/implement-github-feature-and-add-tests-a124
branch
from
e897304 to
7bc76ed
Compare
szokeasaurusrex
pushed a commit
that referenced
this pull request
Jun 24, 2025
szokeasaurusrex
force-pushed
the
cursor/implement-github-feature-and-add-tests-a124
branch
from
7bc76ed to
0626243
Compare
Closes #4474 Co-authored-by: Daniel Szoke <[email protected]>
szokeasaurusrex
force-pushed
the
cursor/implement-github-feature-and-add-tests-a124
branch
from
0626243 to
48f483f
Compare
szokeasaurusrex
deleted the
cursor/implement-github-feature-and-add-tests-a124
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4473.