fix(langchain): Ensure no duplicate SentryLangchainCallback
#4485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
changed the title
SentryLangchainCallback
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #4485 +/- ##
==========================================
- Coverage 80.67% 80.67% -0.01%
==========================================
Files 156 156
Lines 16461 16463 +2
Branches 2799 2799
==========================================
+ Hits 13280 13281 +1
- Misses 2296 2298 +2
+ Partials 885 884 -1
|
szokeasaurusrex
force-pushed
the
szokeasaurusrex/refactor-langchain-args
branch
from
8adbbe7 to
901b579
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/fix-duplicate-langchain-callbacks
branch
from
a42d29f to
ccdd82f
Compare
szokeasaurusrex
added a commit
that referenced
this pull request
Jun 24, 2025
Resolving #4443 requires some changes to this method, but the current `args`/`kwargs` business makes the method difficult to reason through. This PR simplifies the logic by listing out the parameters we need to access, so we don't need to access them through `args` and `kwargs`. We also cut down on the amount of branching and the amount of variables (`new_callbacks` vs `existing_callbacks`). Behavior does not change in this PR; we fix the #4443 bug in #4485, which is based on this PR <!-- Describe your PR here --> --- Thank you for contributing to `sentry-python`! Please add tests to validate your changes, and lint your code using `tox -e linters`. Running the test suite on your PR might require maintainer approval.
Base automatically changed from
szokeasaurusrex/refactor-langchain-args
to
master
June 24, 2025 12:37
Ensure that `SentryLangchainCallback` does not get added twice by also checking the `inheritable_callbacks` Fixes #4443
szokeasaurusrex
force-pushed
the
szokeasaurusrex/fix-duplicate-langchain-callbacks
branch
from
ccdd82f to
083e45a
Compare
sentrivana
approved these changes
Jun 25, 2025
szokeasaurusrex
deleted the
szokeasaurusrex/fix-duplicate-langchain-callbacks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that
SentryLangchainCallbackdoes not get added twice by also checking theinheritable_callbacksFixes #4443