Skip to content

Conversation

@sl0thentr0py
Copy link
Member

It also added performance and aws related files but I want to keep it simple for now.
This adds:

  • quick reference
  • testing guide
  • project overview
  • core architecture
  • integration guide

@sl0thentr0py sl0thentr0py requested a review from a team as a code owner June 18, 2025 14:09
@codecov
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.51%. Comparing base (ae06ef1) to head (d44241f).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4493      +/-   ##
==========================================
- Coverage   80.60%   80.51%   -0.10%     
==========================================
  Files         142      142              
  Lines       16057    16057              
  Branches     2748     2748              
==========================================
- Hits        12943    12928      -15     
- Misses       2245     2266      +21     
+ Partials      869      863       -6     

see 12 files with indirect coverage changes

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels weird but if it makes the cursor experience better...

See comments

- **Descriptive names**: Use clear, descriptive test function names
- **Arrange-Act-Assert**: Structure tests with setup, execution, and verification
- **Isolation**: Each test should be independent and not affect others
- **No mocking**: Never use mocks in tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes there's no way around mocking

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default tests it generated had like 5 mocks and then tested one or two lines of code so really want to avoid that. If you want to use mocks, just write the test yourself for now, if the LLM writes it it should be without mocks.

@sentrivana
Copy link
Contributor

Web 2 should be ok after merging master

@sl0thentr0py
Copy link
Member Author

sl0thentr0py commented Jun 24, 2025

These files are either way not auto-enabled and you need to tag them to use them anyway and it's a start, we will ofc iterate on them as we learn what works best.

Also the way to think about this is what it auto-generated was sort of how it thinks of the codebase anyway, now that it's in rules it's cached and costs less. And we fixed a bit of what was wrong in there.

@sl0thentr0py sl0thentr0py enabled auto-merge (squash) June 24, 2025 10:12
@sl0thentr0py sl0thentr0py merged commit 3e29948 into master Jun 24, 2025
136 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/cursor-rules branch June 24, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants